Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ossm): adds OSSM annotations to the relevant cluster resources #1088

Merged
merged 20 commits into from
Oct 4, 2023

Commits on Jun 28, 2023

  1. feat(ossm): adds OSSM annotations to the relevant cluster resources

    This change takes care of populating the following annotations to resources created through ODH Dashboard
    
    - `opendatahub.io/service-mesh` can be set to `true` or `false` and will be used to alternate ODH components and make them part of the Service Mesh. This is applied on both `Project` and `Notebook` resources
    - `opendatahub.io/hub-url` is added to the `Notebook` resources at this point and is inteded for use with Authorino's `AuthConfig` host
    - The dashboard will now link to notebooks through the mesh if feature flag `disableServiceMesh=false`
    
    In addition, the code hides service-mesh-specific changes to annotations behind `disableServiceMesh` flag which is added in opendatahub-io/opendatahub-operator#217
    
    We have tested this manually. If you can offer us some hints on how to test feature flags and resource creation through Jest tests we are happy to extend this PR with it.
    
    Until this [PR](opendatahub-io/opendatahub-operator#217) is merged and a new bundle is released you can use my build of the ODH Operator that includes the `disableServiceMesh` flag as part of the `ODHDashboardConfig`.
    Do so by running `operator-sdk run bundle quay.io/cgarriso/opendatahub-operator-bundle:dev-0.0.1 --namespace $OPERATOR_NAMESPACE` (req operator-sdk v1.24.1 )
    
    Either build and push this dashboard image or use `quay.io/maistra-dev/odh-dashboard:ossm_annotations` image.
    
    Co-authored-by: bartoszmajsak <[email protected]>
    cam-garrison and bartoszmajsak committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    bfa5075 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1408c29 View commit details
    Browse the repository at this point in the history
  3. fix: use project controller created route for ds project routing (#4)

    * use project annotation for ds project nb routing
    
    * chore: passes host instead of the entire route
    
    and removes hub-url annotation as it is not needed
    
    * remove reference to hub-host
    
    ---------
    
    Co-authored-by: bartoszmajsak <[email protected]>
    cam-garrison and bartoszmajsak committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    166e409 View commit details
    Browse the repository at this point in the history
  4. feat: use annotation to fetch host for notebook routing (#5)

    * update existing annotation reference
    
    * use ns annotation in backend route fetching
    cam-garrison authored and bartoszmajsak committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    47e43ac View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dd22cd7 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Linting fixes

    cam-garrison committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    c917d76 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Configuration menu
    Copy the full SHA
    93aa3ae View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    a0ea817 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    abf520d View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Configuration menu
    Copy the full SHA
    5b26e64 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Configuration menu
    Copy the full SHA
    c106663 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Configuration menu
    Copy the full SHA
    8376c28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    48bfe4e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6b12f82 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Configuration menu
    Copy the full SHA
    ca51ef3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74b4c79 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    b55490f View commit details
    Browse the repository at this point in the history
  2. remove image patch

    cam-garrison committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    2d2244c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    104c88b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df9f285 View commit details
    Browse the repository at this point in the history