-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ossm): adds OSSM annotations to the relevant cluster resources #1088
Merged
Commits on Jun 28, 2023
-
feat(ossm): adds OSSM annotations to the relevant cluster resources
This change takes care of populating the following annotations to resources created through ODH Dashboard - `opendatahub.io/service-mesh` can be set to `true` or `false` and will be used to alternate ODH components and make them part of the Service Mesh. This is applied on both `Project` and `Notebook` resources - `opendatahub.io/hub-url` is added to the `Notebook` resources at this point and is inteded for use with Authorino's `AuthConfig` host - The dashboard will now link to notebooks through the mesh if feature flag `disableServiceMesh=false` In addition, the code hides service-mesh-specific changes to annotations behind `disableServiceMesh` flag which is added in opendatahub-io/opendatahub-operator#217 We have tested this manually. If you can offer us some hints on how to test feature flags and resource creation through Jest tests we are happy to extend this PR with it. Until this [PR](opendatahub-io/opendatahub-operator#217) is merged and a new bundle is released you can use my build of the ODH Operator that includes the `disableServiceMesh` flag as part of the `ODHDashboardConfig`. Do so by running `operator-sdk run bundle quay.io/cgarriso/opendatahub-operator-bundle:dev-0.0.1 --namespace $OPERATOR_NAMESPACE` (req operator-sdk v1.24.1 ) Either build and push this dashboard image or use `quay.io/maistra-dev/odh-dashboard:ossm_annotations` image. Co-authored-by: bartoszmajsak <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bfa5075 - Browse repository at this point
Copy the full SHA bfa5075View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1408c29 - Browse repository at this point
Copy the full SHA 1408c29View commit details -
fix: use project controller created route for ds project routing (#4)
* use project annotation for ds project nb routing * chore: passes host instead of the entire route and removes hub-url annotation as it is not needed * remove reference to hub-host --------- Co-authored-by: bartoszmajsak <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 166e409 - Browse repository at this point
Copy the full SHA 166e409View commit details -
feat: use annotation to fetch host for notebook routing (#5)
* update existing annotation reference * use ns annotation in backend route fetching
Configuration menu - View commit details
-
Copy full SHA for 47e43ac - Browse repository at this point
Copy the full SHA 47e43acView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd22cd7 - Browse repository at this point
Copy the full SHA dd22cd7View commit details
Commits on Jun 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c917d76 - Browse repository at this point
Copy the full SHA c917d76View commit details
Commits on Aug 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 93aa3ae - Browse repository at this point
Copy the full SHA 93aa3aeView commit details
Commits on Aug 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a0ea817 - Browse repository at this point
Copy the full SHA a0ea817View commit details
Commits on Aug 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for abf520d - Browse repository at this point
Copy the full SHA abf520dView commit details
Commits on Aug 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5b26e64 - Browse repository at this point
Copy the full SHA 5b26e64View commit details
Commits on Sep 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c106663 - Browse repository at this point
Copy the full SHA c106663View commit details
Commits on Sep 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8376c28 - Browse repository at this point
Copy the full SHA 8376c28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48bfe4e - Browse repository at this point
Copy the full SHA 48bfe4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b12f82 - Browse repository at this point
Copy the full SHA 6b12f82View commit details
Commits on Sep 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ca51ef3 - Browse repository at this point
Copy the full SHA ca51ef3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74b4c79 - Browse repository at this point
Copy the full SHA 74b4c79View commit details
Commits on Oct 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b55490f - Browse repository at this point
Copy the full SHA b55490fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d2244c - Browse repository at this point
Copy the full SHA 2d2244cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 104c88b - Browse repository at this point
Copy the full SHA 104c88bView commit details -
Configuration menu - View commit details
-
Copy full SHA for df9f285 - Browse repository at this point
Copy the full SHA df9f285View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.