feat(OSSM): introduce disableServiceMesh flag

[cam-garrison]

Description

This flag is used in ODHDashboardConfig to configure notebooks/projects to be handled by the Service Mesh. Without this change the operator will remove disableServiceMesh from the ODHDashboardConfig resource. With this flag we can extend odh-dashboard to handle service mesh enabled deployments.

How Has This Been Tested?

Manually tested by using operator sdk make bundle and deploying on a CRC cluster. Created a KfDef that includes the Service Mesh changes:

kind: KfDef
metadata:
 name: odh-minimal
spec:
 applications:
 - kustomizeConfig:
     repoRef:
       name: manifests
       path: odh-common
   name: odh-common
 - kustomizeConfig:
     repoRef:
       name: manifests
       path: odh-dashboard
   name: odh-dashboard
 - kustomizeConfig:
     repoRef:
       name: manifests
       path: odh-notebook-controller
   name: odh-notebook-controller
 - kustomizeConfig:
     repoRef:
       name: manifests
       path: notebook-images
   name: notebook-images
 repos:
 - name: manifests
   uri: https://github.com/cam-garrison/odh-manifests/tarball/authorino-with-dashboard
 version: authorino

From here follow instructions here to enable service mesh. Tested by adding the disableServiceMesh flag to an existing ODHDashboardConfig object and was able to use the flag succesfully in our fork of odh-dashboard

Additional findings:

It seems that the content of the generated CRDs in the bundle in this repo is out of sync of the actual definitions stored under config. For example the ODHDashboardConfig has few fields missing already

+                  disableModelServing:
+                    type: boolean
+                  disableProjects:
+                    type: boolean

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lavlas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @cam-garrison. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[VaishnaviHire]

@cam-garrison This change needs to be included in the odh-dashboard repo. We have a workflow setup to automatically sync changes from odh-dashboard once they are merged.

[VaishnaviHire]

/ok-to-test

[openshift-ci]

@cam-garrison: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/opendatahub-operator-e2e	262cb99	link	true	/test opendatahub-operator-e2e
ci/prow/opendatahub-manifests-e2e	262cb99	link	false	/test opendatahub-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[cam-garrison]

Closing as this will be handled by the sync job from odh-dashboard and pull from main or service-mesh-integration branch depending on where our dashboard PR is merged to initially.