feat: use annotation to fetch host for notebook routing #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszmajsak
approved these changes
Jun 23, 2023
| @@ -20,5 +20,8 @@ export const getServiceMeshGwHost = async (namespace: string): Promise<string | | |||
| name: namespace, | |||
| }; | |||
| const project = await k8sGetResource<NamespaceKind>({ model: NamespaceModel, queryOptions }); | |||
| return project?.metadata?.annotations?.['opendatahub.io/service-mesh-gw-host'] || null; | |||
| return ( | |||
| project?.metadata?.annotations?.['service-mesh.opendatahub.io/public-gateway-host-external'] || | |||
There was a problem hiding this comment.
As we have service-mesh.opendatahub.io/public-gateway-host-external already in two places can we add it somewhere as a const?
There was a problem hiding this comment.
I don't think so - the two references are found in the frontend/ and backend/ sections of the codebase respectively - and I don't think that the two share consts (from what I can see).
bartoszmajsak
pushed a commit
that referenced
this pull request
Jun 28, 2023
* update existing annotation reference * use ns annotation in backend route fetching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the route fetching logic to use the new
"service-mesh.opendatahub.io/public-gateway-host-external"namespace annotation when routing to a notebook.This prevents unnecessary route fetching from the
istio-systemnamespace, and makes the logic between fetching a JupyterHub route from the main dashboard and from a Workbench created in a Data Science Project consistent.