Merge pull request #1960 from ppadti/issue-1857

Cleanup Empty State Text
opendatahub-io · Nov 30, 2023 · b1bcc05 · b1bcc05
2 parents 288d890 + df8c6e7
commit b1bcc05
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 31 deletions.
diff --git a/frontend/src/concepts/pipelines/NoPipelineServer.tsx b/frontend/src/concepts/pipelines/NoPipelineServer.tsx
@@ -2,7 +2,6 @@ import * as React from 'react';
 import {
   EmptyState,
   EmptyStateIcon,
-  EmptyStateBody,
   EmptyStateHeader,
   EmptyStateFooter,
 } from '@patternfly/react-core';
@@ -20,9 +19,6 @@ const NoPipelineServer: React.FC<NoPipelineServerProps> = ({ variant }) => (
       icon={<EmptyStateIcon icon={WrenchIcon} />}
       headingLevel="h3"
     />
-    <EmptyStateBody>
-      To create and manage pipelines, first enable them by configuring a pipeline server.
-    </EmptyStateBody>
     <EmptyStateFooter>
       <CreatePipelineServerButton variant={variant} />
     </EmptyStateFooter>

diff --git a/frontend/src/pages/modelServing/screens/projects/ModelServingPlatform.tsx b/frontend/src/pages/modelServing/screens/projects/ModelServingPlatform.tsx
@@ -106,11 +106,6 @@ const ModelServingPlatform: React.FC = () => {
         emptyState={
           <EmptyDetailsList
             title={isProjectModelMesh ? 'No model servers' : 'No deployed models'}
-            description={
-              isProjectModelMesh
-                ? 'Before deploying a model, you must first add a model server.'
-                : 'To get started, deploy a model.'
-            }
             icon={PlusCircleIcon}
           />
         }

diff --git a/frontend/src/pages/projects/screens/detail/EmptyDetailsList.tsx b/frontend/src/pages/projects/screens/detail/EmptyDetailsList.tsx
@@ -10,7 +10,7 @@ import { SVGIconProps } from '@patternfly/react-icons/dist/esm/createIcon';
 
 type EmptyDetailsListProps = {
   title: string;
-  description: string;
+  description?: string;
   icon?: React.ComponentClass<SVGIconProps>;
 };
 

diff --git a/frontend/src/pages/projects/screens/detail/data-connections/DataConnectionsList.tsx b/frontend/src/pages/projects/screens/detail/data-connections/DataConnectionsList.tsx
@@ -34,12 +34,7 @@ const DataConnectionsList: React.FC = () => {
         isLoading={!loaded}
         isEmpty={isDataConnectionsEmpty}
         loadError={error}
-        emptyState={
-          <EmptyDetailsList
-            title="No data connections"
-            description="To get started, add data to your project."
-          />
-        }
+        emptyState={<EmptyDetailsList title="No data connections" />}
       >
         <DataConnectionsTable connections={connections} refreshData={refreshAllProjectData} />
       </DetailsSection>

diff --git a/frontend/src/pages/projects/screens/detail/notebooks/NotebookList.tsx b/frontend/src/pages/projects/screens/detail/notebooks/NotebookList.tsx
@@ -44,12 +44,7 @@ const NotebookList: React.FC = () => {
         isLoading={!loaded}
         loadError={loadError}
         isEmpty={isNotebooksEmpty}
-        emptyState={
-          <EmptyDetailsList
-            title="No workbenches"
-            description="To get started, create a workbench."
-          />
-        }
+        emptyState={<EmptyDetailsList title="No workbenches" />}
       >
         <NotebookTable notebookStates={notebookStates} refresh={refresh} />
       </DetailsSection>

diff --git a/frontend/src/pages/projects/screens/detail/pipelines/PipelinesList.tsx b/frontend/src/pages/projects/screens/detail/pipelines/PipelinesList.tsx
@@ -39,9 +39,7 @@ const PipelinesList: React.FC<PipelinesListProps> = ({ setIsPipelinesEmpty }) =>
   }
 
   if (pipelines.length === 0) {
-    return (
-      <EmptyDetailsList title="No pipelines" description="To get started, import a pipeline." />
-    );
+    return <EmptyDetailsList title="No pipelines" />;
   }
 
   return (

diff --git a/frontend/src/pages/projects/screens/detail/storage/StorageList.tsx b/frontend/src/pages/projects/screens/detail/storage/StorageList.tsx
@@ -34,12 +34,7 @@ const StorageList: React.FC = () => {
         isLoading={!loaded}
         isEmpty={isPvcsEmpty}
         loadError={loadError}
-        emptyState={
-          <EmptyDetailsList
-            title="No storage"
-            description="To get started, add existing or create new cluster storage."
-          />
-        }
+        emptyState={<EmptyDetailsList title="No storage" />}
       >
         <StorageTable pvcs={pvcs} refresh={refresh} onAddPVC={() => setOpen(true)} />
       </DetailsSection>