Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Empty State Text #1960

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Oct 12, 2023

Closes: #1857

Description

This PR aims to cleanup empty state text on each of our sections in the Projects view, that is redundant.

Screenshot from 2023-10-12 00-56-24

Screenshot from 2023-11-30 19-19-34

Screenshot from 2023-11-03 13-28-49

Screenshot from 2023-11-30 19-14-21

Screenshot from 2023-11-30 19-30-26

Screenshot from 2023-11-03 13-24-41

How Has This Been Tested?

Create a new data science project and check each section in project view.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ppadti
Copy link
Contributor Author

ppadti commented Oct 12, 2023

cc @andrewballantyne Just reconfirming, whether these are the changes you were expecting from this PR?

@dpanshug
Copy link
Contributor

@andrewballantyne Instead of removing EmptyState description, can't we change it to something meaningful? wdyt @kaedward ?

@andrewballantyne
Copy link
Member

@andrewballantyne Instead of removing EmptyState description, can't we change it to something meaningful? wdyt @kaedward ?

This was out of the UX test sessions with Data Scientists feedback with Marc; it was found to be redundant given the action item for each section. @kaedward you get the last say, but both Kyle and I are in agreement this was desired.

@kaedward
Copy link

This was out of the UX test sessions with Data Scientists feedback with Marc; it was found to be redundant given the action item for each section. @kaedward you get the last say, but both Kyle and I are in agreement this was desired.

I agree with removing the description! @andrewballantyne

@andrewballantyne
Copy link
Member

andrewballantyne commented Nov 17, 2023

I can't resolve this today as there is a conflict. @ppadti please rebase.

For UX, here is the before and after... (if they are happy with the change, we can merge this once the conflict is resolved)


Before

Screenshot 2023-11-17 at 12 31 00 PM
Screenshot 2023-11-17 at 12 31 27 PM
Screenshot 2023-11-17 at 12 31 49 PM


After

Screenshot 2023-11-17 at 12 30 52 PM
Screenshot 2023-11-17 at 12 31 20 PM
Screenshot 2023-11-17 at 12 31 39 PM

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Nov 17, 2023
@kywalker-rh
Copy link

Looks good to me. Thanks for updating it!

@openshift-ci openshift-ci bot added the lgtm label Nov 30, 2023
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b1bcc05 into opendatahub-io:main Nov 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Cleanup Empty State Text
8 participants