-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Empty State Text #1960
Cleanup Empty State Text #1960
Conversation
cc @andrewballantyne Just reconfirming, whether these are the changes you were expecting from this PR? |
@andrewballantyne Instead of removing EmptyState description, can't we change it to something meaningful? wdyt @kaedward ? |
This was out of the UX test sessions with Data Scientists feedback with Marc; it was found to be redundant given the action item for each section. @kaedward you get the last say, but both Kyle and I are in agreement this was desired. |
I agree with removing the description! @andrewballantyne |
I can't resolve this today as there is a conflict. @ppadti please rebase. For UX, here is the before and after... (if they are happy with the change, we can merge this once the conflict is resolved) BeforeAfter |
Looks good to me. Thanks for updating it! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: #1857
Description
This PR aims to cleanup empty state text on each of our sections in the Projects view, that is redundant.
How Has This Been Tested?
Create a new data science project and check each section in project view.
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main