Merge pull request #2239 from lucferbux/issue-2238

Enable modelmesh on cluster creation
opendatahub-io · Nov 29, 2023 · 288d890 · 288d890
2 parents cb7cc6f + 9dcdfdb
commit 288d890
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/backend/src/utils/constants.ts b/backend/src/utils/constants.ts
@@ -55,7 +55,7 @@ export const blankDashboardCR: DashboardConfig = {
       modelMetricsNamespace: '',
       disablePipelines: false,
       disableKServe: false,
-      disableModelMesh: true,
+      disableModelMesh: false,
     },
     notebookController: {
       enabled: true,

diff --git a/docs/dashboard-config.md b/docs/dashboard-config.md
@@ -25,7 +25,7 @@ The following are a list of features that are supported, along with there defaul
 | disableProjectSharing        | false   | Disables Project Sharing from Data Science Projects.                                                 |
 | disableCustomServingRuntimes | false   | Disables Custom Serving Runtimes from the Admin Panel.                                               |
 | disableKServe                | false   | Disables the ability to select KServe as a Serving Platform.                                         |
-| disableModelMesh             | true    | Disables the ability to select ModelMesh as a Serving Platform.                                      |
+| disableModelMesh             | false   | Disables the ability to select ModelMesh as a Serving Platform.                                      |
 | modelMetricsNamespace        | false   | Enables the namespace in which the Model Serving Metrics' Prometheus Operator is installed.          |
 
 ## Defaults

diff --git a/frontend/src/__mocks__/mockDashboardConfig.ts b/frontend/src/__mocks__/mockDashboardConfig.ts
@@ -31,7 +31,7 @@ export const mockDashboardConfig = ({
   disableCustomServingRuntimes = false,
   disablePipelines = false,
   disableKServe = false,
-  disableModelMesh = true,
+  disableModelMesh = false,
 }: MockDashboardConfigType): DashboardConfigKind => ({
   apiVersion: 'opendatahub.io/v1alpha',
   kind: 'OdhDashboardConfig',

diff --git a/frontend/src/__tests__/integration/pages/customServingRuntimes/CustomServingRuntimes.spec.ts b/frontend/src/__tests__/integration/pages/customServingRuntimes/CustomServingRuntimes.spec.ts
@@ -8,7 +8,7 @@ test('Custom serving runtimes', async ({ page }) => {
 
   // check the platform setting labels in the header
   await expect(page.getByText('Single model serving enabled')).toBeVisible();
-  await expect(page.getByText('Multi-model serving enabled')).toBeHidden();
+  await expect(page.getByText('Multi-model serving enabled')).toBeVisible();
 
   // check the platform labels in the table row
   await expect(page.locator('#template-1').getByLabel('Label group category')).toHaveText(

diff --git a/frontend/src/pages/modelServing/screens/projects/ModelServingPlatformSelect.tsx b/frontend/src/pages/modelServing/screens/projects/ModelServingPlatformSelect.tsx
@@ -46,7 +46,7 @@ const ModelServingPlatformSelect: React.FC<ModelServingPlatformSelectProps> = ({
                 />
               }
               title="Single model serving platform"
-              description="Each model is deployed from its own model server. Choose this option when you have a small number of large models to deploy."
+              description="Each model is deployed from its own model server. Choose this option only for large language models that will be deployed using the Caikit runtime."
             />
           </GalleryItem>
           <GalleryItem>

diff --git a/manifests/overlays/odhdashboardconfig/odh-dashboard-config.yaml b/manifests/overlays/odhdashboardconfig/odh-dashboard-config.yaml
@@ -20,7 +20,7 @@ spec:
     disableCustomServingRuntimes: true
     modelMetricsNamespace: ''
     disableKServe: false
-    disableModelMesh: true
+    disableModelMesh: false
   notebookController:
     enabled: true
   notebookSizes: