go.mod, libct: switch to google.golang.org/protobuf #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
force-pushed
the
google-golang-protobuf
branch
2 times, most recently
from
04311aa
to
a186be1
Compare
|
The binary size has actually decreased a bit: For go 1.15: [kir@kir-rhat runc]$ size runc.*15
text data bss dec hex filename
7790881 3968272 221488 11980641 b6cf61 runc.goog.go115
7806321 3972945 221584 12000850 b71e52 runc.master.go115For go 1.16: [kir@kir-rhat runc]$ size runc.*16
text data bss dec hex filename
7176335 3658240 222488 11057063 a8b7a7 runc.goog.go116
7199983 3664080 222616 11086679 a92b57 runc.master.go116 |
kolyshkin
force-pushed
the
google-golang-protobuf
branch
from
ccd1524
to
22c12ac
Compare
kolyshkin
force-pushed
the
google-golang-protobuf
branch
from
22c12ac
to
d8563ba
Compare
In case log level is less than debug, this code does nothing, so let's add a condition and skip it entirely. Add a test case to make sure this code path is hit. Signed-off-by: Kir Kolyshkin <[email protected]>
Switch from github.com/golang/protobuf (which appears to be obsoleted) to google.golang.org/protobuf (which appears to be a replacement). This needs a bump to go-criu v5. [v2: fix debug print in criuSwrk] [v3: switch to go-criu v5] Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
google-golang-protobuf
branch
from
d8563ba
to
97f2e35
Compare
|
No longer a draft. @adrianreber @AkihiroSuda @mrunalp PTAL |
|
cross-i386 failed with: This is a temp github issue :( which I'm seeing for the first time, and I think we can use curl's retry to mitigate. Opened #2833 |
Merged
AkihiroSuda
approved these changes
Mar 10, 2021
|
Ughm... I have almost reimplemented the first commit of this PR from scratch when I was looking into the checkpointing code today -- thought I never finished it. |
mrunalp
approved these changes
Mar 31, 2021
|
close/open to re-kick ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from github.com/golang/protobuf (which appears to be obsoleted)
to google.golang.org/protobuf (which appears to be a replacement).
This needs a bump of checkpoint-restore/go-criu to include
checkpoint-restore/go-criu#43.
Addresses: #2627 (#2627 (comment))
NOTE: this is a draft since it uses an untagged version of go-criu. Once a tagged release is available, I'll update this PR and move it out of draft