Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang protobuf bump #36

Closed
kolyshkin opened this issue Dec 3, 2020 · 5 comments
Closed

golang protobuf bump #36

kolyshkin opened this issue Dec 3, 2020 · 5 comments

Comments

@kolyshkin
Copy link
Contributor

README for https://github.com/golang/protobuf says:

It has been superseded by the google.golang.org/protobuf module, which contains an updated and simplified API, support for protobuf reflection, and many other improvements. We recommend that new code use the google.golang.org/protobuf module.

Versions v1.4 and later of github.com/golang/protobuf are implemented in terms of google.golang.org/protobuf. Programs which use both modules must use at least version v1.4 of this one.

Meaning we need to either switch to google.golang.org/protobuf, or at least use github.com/golang/protobuf v.1.4+.

@kolyshkin
Copy link
Contributor Author

This needs to be coordinated with runc of course.

@kolyshkin
Copy link
Contributor Author

Should be ixed by #38 and #43

@kolyshkin
Copy link
Contributor Author

Tested with runc: opencontainers/runc#2807. Had to made a change for debug print of criu options as they are now represented slightly different (XXX_* are gone, all-lowercase are added).

@adrianreber can you please make a release?

@kolyshkin
Copy link
Contributor Author

Since #46 we'll have to switch to v5 anyway, so maybe make a release once you merge it @adrianreber

@kolyshkin
Copy link
Contributor Author

Fixed by #38 and #43, with #46 as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant