-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protobuf files and go mod/sum #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brought to you by # (bring in latest protoc-gen-go) go get github.com/golang/protobuf/protoc-gen-go # (regen for github.com/golang/[email protected]) make -B rpc/rpc.pb.go This prepares the code to be switched to google.golang.org/protobuf/proto Signed-off-by: Kir Kolyshkin <[email protected]>
Same as commit 654aa39 did for rpc/*. Signed-off-by: Kir Kolyshkin <[email protected]>
This should prepare the code to switch to using google.golang.org/protobuf/proto Signed-off-by: Kir Kolyshkin <[email protected]>
Brought to you by cd phaul && go build . This adds - golang.org/x/sys/unix because it is used by phaul; - google.golang.org/protobuf because it is used by *.pb.go stuff. Signed-off-by: Kir Kolyshkin <[email protected]>
Closed
@adrianreber @rst0git PTAL |
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Feb 12, 2021
Switch from github.com/golang/protobuf (which appears to be obsoleted) to google.golang.org/protobuf (which appears to be a replacement). This needs a bump of checkpoint-restore/go-criu to include checkpoint-restore/go-criu#43. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Feb 13, 2021
Switch from github.com/golang/protobuf (which appears to be obsoleted) to google.golang.org/protobuf (which appears to be a replacement). This needs a bump of checkpoint-restore/go-criu to include checkpoint-restore/go-criu#43. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Feb 13, 2021
Switch from github.com/golang/protobuf (which appears to be obsoleted) to google.golang.org/protobuf (which appears to be a replacement). This needs a bump of checkpoint-restore/go-criu to include checkpoint-restore/go-criu#43. [v2: fix debug print in criuSwrk] Signed-off-by: Kir Kolyshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #38, addressing #36.
This updates
stats/stats.pb.go
andrpc/rpc.pb.go
to versions generated by latest protoc-gen-go. This makes them compatible with github.com/golang/[email protected] as well as google.golang.org/protobuf/proto.This also updates go.mod and go.sum, adding golang.org/x/sys/unix (used by phaul) and google.golang.org/protobuf (used by *.pb.go).
See more details in commit messages.