Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new annotation fields #1604

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

BenjaSanchez
Copy link
Contributor

@BenjaSanchez BenjaSanchez commented Sep 2, 2020

Following #1591, added some more annotation fields, for reactions and metabolites:

  • Reactions: metEnviPathID, metLIPIDMAPSID, metSABIORKID, metSLMID.
  • Metabolites: rxnKEGGPathways, rxnSABIORKID.

The DBPatterns are taken from https://registry.identifiers.org/registry

Note that the qualifier for rxnKEGGPathways was set to isVersionOf while all other ones were set to is, based on the definitions at https://co.mbine.org/standards/qualifiers

EDIT: Tested at BenjaSanchez/yeast-GEM@9b2a8e2

I hereby confirm that I have:

  • Tested my code on my own machine
  • Followed the guidelines in the Contributing Guide
  • Selected develop as a target branch (top left drop-down menu)

@rmtfleming rmtfleming merged commit 65aa4e1 into opencobra:develop Sep 7, 2020
BenjaSanchez added a commit to SysBioChalmers/yeast-GEM that referenced this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants