Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update COBRA+RAVEN toolboxes #253

Merged
merged 3 commits into from
Nov 25, 2020
Merged

Conversation

BenjaSanchez
Copy link
Contributor

@BenjaSanchez BenjaSanchez commented Nov 24, 2020

Main improvements in this PR:

Updated COBRA and RAVEN to their latest versions, with the following effects:

NB: In order to be compliant with the new exporting structure introduced in SysBioChalmers/RAVEN#303, saveYeastModel was temporally adapted, until we switch to the standard-GEM format (more discussion at #232).

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)

* change in yml: use of quotes for fields (SysBioChalmers/RAVEN#309)
* adpated saveYeastModel to be compliant with new exporting structure introduced in SysBioChalmers/RAVEN#303 (temporal)
@BenjaSanchez BenjaSanchez added the enhancement new field/feature label Nov 24, 2020
@BenjaSanchez BenjaSanchez self-assigned this Nov 24, 2020
Copy link
Collaborator

@hongzhonglu hongzhonglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@BenjaSanchez BenjaSanchez merged commit d28afbe into devel Nov 25, 2020
@BenjaSanchez BenjaSanchez deleted the chore/update-toolboxes branch November 25, 2020 10:12
This was referenced Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new field/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants