Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model with id on name don't generate markdown docs #151

Closed
maryliag opened this issue May 8, 2024 · 0 comments · Fixed by #152
Closed

model with id on name don't generate markdown docs #151

maryliag opened this issue May 8, 2024 · 0 comments · Fixed by #152

Comments

@maryliag
Copy link

maryliag commented May 8, 2024

Describe the bug
When a model has a number on its id, the update markdown command doesn't work. It doesn't return any error, it just doesn't update the file.

To Reproduce
Example that doesn't work:
yaml file

- id: metric.namewithnumber1
    type: metric
    metric_name: namewithnumber1

readme file

<!-- semconv metric.namewithnumber1(metric_table) -->
<!-- endsemconv -->

Example that works:
yaml file

- id: metric.namewithnumber
    type: metric
    metric_name: namewithnumber1

readme file

<!-- semconv metric.namewithnumber(metric_table) -->
<!-- endsemconv -->

Expected behavior
Doc to be generated correctly or if there is a problem with the id name it should show some error message.

jsuereth added a commit to jsuereth/weaver that referenced this issue May 9, 2024
Current parsing is a bit inflexible, improve parsing to include more.
jsuereth added a commit that referenced this issue May 9, 2024
Current parsing is a bit inflexible, improve parsing to include more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant