(fix) Expand id parsing #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current parsing is a bit inflexible, improve parsing to include more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
=======================================
- Coverage 73.4% 73.4% -0.1%
=======================================
Files 44 44
Lines 2504 2503 -1
=======================================
- Hits 1840 1839 -1
Misses 664 664 ☔ View full report in Codecov by Sentry. |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current parsing is a bit inflexible, improve parsing to include more.
Fixes #151
This is a fast update. Longer term, we should have a very "loose" parsing grammar for recognizing tags where we can issue errors if the tags don't match our current parser, due, e.g. to poor tag syntax.