Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update model IDs from text to number when applicable #1173

Closed
maryliag opened this issue Jun 20, 2024 · 0 comments · Fixed by #1314 or #1352
Closed

update model IDs from text to number when applicable #1173

maryliag opened this issue Jun 20, 2024 · 0 comments · Fixed by #1314 or #1352
Labels
enhancement New feature or request tooling Regarding build, workflows, build-tools, ...

Comments

@maryliag
Copy link
Contributor

maryliag commented Jun 20, 2024

Is your change request related to a problem? Please describe.

Due to a limitation on weaver, IDs of model could not contain numbers, so veight was added instead of v8 on the IDs of the PR #1066, and pfifty, pninety and pninety-nine on #991

Describe the solution you'd like

Once a version of weaver that includes the fix of open-telemetry/weaver#151 is updated on this repo, the value of veight on model IDs can be updated to v8 to keep consistency with the metric name, same for using p50, p90, p99

@maryliag maryliag added enhancement New feature or request triage:needs-triage labels Jun 20, 2024
@maryliag maryliag changed the title update veight to v8 on model IDS update model IDs from text to number when applicable Jun 20, 2024
@lmolkova lmolkova added tooling Regarding build, workflows, build-tools, ... and removed triage:needs-triage labels Jun 21, 2024
@joaopgrassi joaopgrassi self-assigned this Jun 21, 2024
@joaopgrassi joaopgrassi removed their assignment Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tooling Regarding build, workflows, build-tools, ...
Projects
Archived in project
4 participants