-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename db.client.connections.*
metrics to db.client.connection.*
and rename db.client.connection.usage
to db.client.connection.count
and adapting units
#966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may be worth fixing #967 in this PR also
…egkalapos/semantic-conventions into RenameDbClientConnectionUsage
Fix ids
db.client.connections.usage
to db.client.connections.count
db.client.connections.*
metrics to db.client.connection.*
and rename db.client.connection.usage
to db.client.connection.count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregkalapos sorry, I realized it would be good to add one more change to this PR: #381
bundling #381 here would have the advantage that we know the old name is always associated with milliseconds and the new name is always associated with seconds
(and it would affect the schema translation, where the metrics that changed from milliseconds to seconds would no longer be considered renames)
db.client.connections.*
metrics to db.client.connection.*
and rename db.client.connection.usage
to db.client.connection.count
db.client.connections.*
metrics to db.client.connection.*
and rename db.client.connection.usage
to db.client.connection.count
and adapting units
CI fails,
Update: issue about this: #987 |
…and rename `db.client.connection.usage` to `db.client.connection.count` and adapting units (open-telemetry#966) Co-authored-by: Liudmila Molkova <[email protected]>
Fixes #967
Fixes #201
Fixes #381
Changes
As described in #201 and discussed in the DB Semconv Stability WG meeting:
db.client.connection.usage
->db.client.connection.count
. Also fixing #967 and renaming thedb.client.connections.*
metrics namespace todb.client.connection.*
.Since this PR already changes Db metrics, also adapting unit from
ms
tos
as described in #381.Merge requirement checklist
[chore]