Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] All PRs fail on docfx check #987

Closed
AlexanderWert opened this issue Apr 30, 2024 · 3 comments · Fixed by #1008
Closed

[CI] All PRs fail on docfx check #987

AlexanderWert opened this issue Apr 30, 2024 · 3 comments · Fixed by #1008
Assignees
Labels
bug Something isn't working

Comments

@AlexanderWert
Copy link
Member

Area(s)

No response

What happened?

PR builds fail on the docfx job (even PRs that succeeded before, if rerunning that job), with the following error message:
image

Something is wrong with the installation step of docfx.

Semantic convention version

N/A

Additional context

No response

@gregkalapos
Copy link
Member

It seems this step fetches docfx v. 3.0 from a custom NuGet feed. V3 has never been publically released, on public NuGet the latest version is v2.76.0. It seems now there is nothing behind this custom NuGet feed from https://docfx.pkgs.visualstudio.com/docfx/. They have a v3 branch (last commit 2 years ago), I suspect it's a build from that branch.

Here is a super old discussion about v3 release: dotnet/docfx#7050.

The step runs docfx build --dry-run, which doesn't seem to be present in 2.x, only in 3.x.

@lmolkova
Copy link
Contributor

FYI: dotnet/docfx#9901

@lmolkova
Copy link
Contributor

lmolkova commented May 1, 2024

Thanks to @jsuereth docfx check is not required and we can merge PRs despite it showing errors until we figure out what to do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants