-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use seconds as default duration for DB client metrics #381
Comments
the initial database semantic convention stability isn't targeting these metrics, but it makes sense to me to make these changes as part of the stability effort so that they can be grouped with the other database semconv breaking changes |
I agree. Consumers of db semantic conventions will already be dealing with significant breaking changes. Withholding changes to part of the conventions because they're not targeted for stability is probably detrimental to the user experience. |
As suggested by @trask #966 (review) doing it in #966 |
This issue was created based on a discussion about #176.
General guidelines for metric instrumentation units require that for measuring durations, seconds should be used:
However, the following DB client metrics still use milliseconds for measuring durations:
db.client.connections.create_time
db.client.connections.wait_time
db.client.connections.use_time
For consistency, those histograms should be changed to use seconds. Those metrics are already in use, and to avoid unnecessary disruptions the change should happen during stabilization of DB semantic conventions and should be covered by the
OTEL_SEMCONV_STABILITY_OPT_IN
mechanism.The text was updated successfully, but these errors were encountered: