Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s.volume.{name,type} attributes #1251

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jul 15, 2024

Fixes #1164

Changes

Please provide a brief description of the changes here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Add k8s.volume.{name,type} attributes.

From https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.102.0/receiver/kubeletstatsreceiver/internal/kubelet/conventions.go#L7

Merge requirement checklist

Sorry, something went wrong.

@ChrsMark ChrsMark requested review from a team July 15, 2024 10:31
@ChrsMark ChrsMark force-pushed the add_k8s_volume_type branch 6 times, most recently from c27b687 to d147900 Compare July 16, 2024 07:34
model/resource/k8s.yaml Outdated Show resolved Hide resolved
@ChrsMark ChrsMark requested a review from jsuereth July 26, 2024 13:40
@ChrsMark ChrsMark force-pushed the add_k8s_volume_type branch from 9ac2bab to 9f93b42 Compare August 2, 2024 10:43
@ChrsMark
Copy link
Member Author

ChrsMark commented Aug 2, 2024

@open-telemetry/semconv-k8s-approvers could you take a look?

model/registry/k8s.yaml Outdated Show resolved Hide resolved
model/registry/k8s.yaml Outdated Show resolved Hide resolved
.chloggen/add_k8s_volume_type.yaml Outdated Show resolved Hide resolved
model/registry/k8s.yaml Outdated Show resolved Hide resolved
@ChrsMark ChrsMark force-pushed the add_k8s_volume_type branch from b83bfbe to 15e3207 Compare August 5, 2024 06:19
@ChrsMark ChrsMark requested a review from lmolkova August 5, 2024 06:19
@ChrsMark
Copy link
Member Author

ChrsMark commented Aug 5, 2024

Thank's @lmolkova for the comments! Should be addressed now.

model/registry/k8s.yaml Outdated Show resolved Hide resolved
model/registry/k8s.yaml Outdated Show resolved Hide resolved
@ChrsMark
Copy link
Member Author

ChrsMark commented Aug 8, 2024

Hey @jsuereth, could you take another look please?

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark force-pushed the add_k8s_volume_type branch from 62bbbf4 to 013e448 Compare August 14, 2024 07:36
@ChrsMark
Copy link
Member Author

The failure is unrelated. I have filed #1332 to fix this.

@jsuereth jsuereth merged commit e31ed0f into open-telemetry:main Aug 14, 2024
12 of 13 checks passed
ezimuel pushed a commit to ezimuel/semantic-conventions that referenced this pull request Aug 20, 2024

Verified

This commit was signed with the committer’s verified signature.
ezimuel Enrico Zimuel
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add k8s.volume.type attribute
5 participants