address review comments

Signed-off-by: ChrsMark <[email protected]>
open-telemetry · Aug 5, 2024 · 15e3207 · 15e3207
1 parent 39f81bc
commit 15e3207
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/.chloggen/add_k8s_volume_type.yaml b/.chloggen/add_k8s_volume_type.yaml
@@ -10,7 +10,7 @@ change_type: enhancement
 component: k8s
 
 # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
-note: Adds k8s.volume.name and k8s.volume.type in the registry
+note: Adds `k8s.volume.name` and `k8s.volume.type` attributes to the registry
 
 # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
 # The values here must be integers.

diff --git a/docs/attributes-registry/k8s.md b/docs/attributes-registry/k8s.md
@@ -69,7 +69,6 @@ conflict.
 
 | Value                   | Description                                                                                                             | Stability                                                        |
 | ----------------------- | ----------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------- |
-| `awsElasticBlockStore`  | An [awsElasticBlockStore](https://v1-29.docs.kubernetes.io/docs/concepts/storage/volumes/#awselasticblockstore) volume  | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
 | `configMap`             | A [configMap](https://v1-29.docs.kubernetes.io/docs/concepts/storage/volumes/#configmap) volume                         | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
 | `downwardAPI`           | A [downwardAPI](https://v1-29.docs.kubernetes.io/docs/concepts/storage/volumes/#downwardapi) volume                     | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
 | `emptyDir`              | An [emptyDir](https://v1-29.docs.kubernetes.io/docs/concepts/storage/volumes/#emptydir) volume                          | ![Experimental](https://img.shields.io/badge/-experimental-blue) |

diff --git a/model/registry/k8s.yaml b/model/registry/k8s.yaml
@@ -189,21 +189,20 @@ groups:
           The type of the K8s volume.
         examples: [ "emptyDir", "persistentVolumeClaim" ]
         type:
-          allow_custom_values: true
           members:
-            - id: persistentvolumeclaim
+            - id: persistent_volume_claim
               value: 'persistentVolumeClaim'
               brief: "A [persistentVolumeClaim](https://v1-29.docs.kubernetes.io/docs/concepts/storage/volumes/#persistentvolumeclaim) volume"
               stability: experimental
-            - id: configmap
+            - id: config_map
               value: 'configMap'
               brief: "A [configMap](https://v1-29.docs.kubernetes.io/docs/concepts/storage/volumes/#configmap) volume"
               stability: experimental
-            - id: downwardapi
+            - id: downward_api
               value: 'downwardAPI'
               brief: "A [downwardAPI](https://v1-29.docs.kubernetes.io/docs/concepts/storage/volumes/#downwardapi) volume"
               stability: experimental
-            - id: emptydir
+            - id: empty_dir
               value: 'emptyDir'
               brief: "An [emptyDir](https://v1-29.docs.kubernetes.io/docs/concepts/storage/volumes/#emptydir) volume"
               stability: experimental
@@ -215,11 +214,7 @@ groups:
               value: 'local'
               brief: "A [local](https://v1-29.docs.kubernetes.io/docs/concepts/storage/volumes/#local) volume"
               stability: experimental
-            - id: awselasticblockstore
-              value: 'awsElasticBlockStore'
-              brief: "An [awsElasticBlockStore](https://v1-29.docs.kubernetes.io/docs/concepts/storage/volumes/#awselasticblockstore) volume"
-              stability: experimental
-            - id: gcepersistentdisk
+            - id: gce_persistent_disk
               value: 'gcePersistentDisk'
               brief: "A [gcePersistentDisk](https://v1-29.docs.kubernetes.io/docs/concepts/storage/volumes/#gcepersistentdisk) volume"
               stability: experimental