Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s.volume.type attribute #1164

Closed
ChrsMark opened this issue Jun 19, 2024 · 3 comments · Fixed by #1251
Closed

Add k8s.volume.type attribute #1164

ChrsMark opened this issue Jun 19, 2024 · 3 comments · Fixed by #1251
Assignees
Labels
area:k8s enhancement New feature or request

Comments

@ChrsMark
Copy link
Member

ChrsMark commented Jun 19, 2024

Area(s)

area:k8s

Is your change request related to a problem? Please describe.

kubeletstats receiver provides support for adding the k8s.volume.type attribute along with the volume related metrics: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.102.0/receiver/kubeletstatsreceiver/internal/kubelet/conventions.go#L7.

Describe the solution you'd like

We need to define a Semantic Convention for this attribute.

Describe alternatives you've considered

No response

Additional context

Related to #1119 and #1032.

/cc @open-telemetry/semconv-k8s-approvers

@ChrsMark ChrsMark added enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage labels Jun 19, 2024
@ChrsMark ChrsMark removed the experts needed This issue or pull request is outside an area where general approvers feel they can approve label Jun 19, 2024
@TylerHelmuth
Copy link
Member

This attribute has been in use for a long time successfully, officially merging it here makes sense to me

@joaopgrassi
Copy link
Member

@ChrsMark will you take this? Should I move to the system semconv project board?

@ChrsMark
Copy link
Member Author

ChrsMark commented Jul 9, 2024

@joaopgrassi I can assign this to me and work on it in the near future unless there is anybody else willing to pick it up earlier.

This does not fall into the system semconv project. The System Metrics WG only focuses on host/system metrics and attributes.
This can be tracked by #1032 until we form a K8s WG, hopefully some time soon :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:k8s enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants