-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attributes should only have default values if supplying the attribute is (otherwise) required #385
Comments
It looks like these are the (HTTP) attributes potentially in this boat:
|
- ref: network.protocol.name | |
examples: ['http', 'spdy'] | |
requirement_level: | |
recommended: if not default (`http`). |
server.port
(on server side)
semantic-conventions/model/trace/http.yaml
Lines 92 to 95 in b127e12
- ref: server.port | |
sampling_relevant: true | |
requirement_level: | |
recommended: If not default (`80` for `http` scheme, `443` for `https`). |
I'm not sure if we can conditionally require For |
I don't think we can solve this by just saying "there is no default value". In effect, this is a recommendation for backends which assumption to make if they need one. If we remove it and backends still need to know the value, they will still make an assumption. |
The alternative is to remove Backends can safely assume |
Agree, I'm surprised it's recommended |
We might have lost the requirement for the port by mistake, since http.host contained the port as well. |
In order to avoid ambiguity between default attribute value and unknown attribute value.
motivated by @lmolkova's #373 (comment):
The text was updated successfully, but these errors were encountered: