Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider requirement level of network.protocol.name #477

Closed
trask opened this issue Oct 31, 2023 · 0 comments · Fixed by #478
Closed

Reconsider requirement level of network.protocol.name #477

trask opened this issue Oct 31, 2023 · 0 comments · Fixed by #478
Assignees

Comments

@trask
Copy link
Member

trask commented Oct 31, 2023

From @mateuszrzeszutek

one thing that I haven’t implemented yet is the network.protocol.name opt-in attribute — right now we’re exporting it all the time
we’ve briefly talked about it in the last SIG meeting, I’m slightly opposed to removing it — to me the network.protocol.(name|version) make a pair, and sending just the version seems incomplete

and also we have some legacy HTTP clients that still technically support the deprecated protocols

network.protocol.name was changed from recommended to opt-in because:

I think we may be able to address this by making network.protocol.name conditionally required when network.protocol.version is provided, and making http the default value (only) when network.protocol.version is provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants