Change network.protocol.name from recommended to opt-in in the HTTP semconv
#398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
remove-network-protocol-name-from-http-semconv
branch
from
70b303f to
3b8de0a
Compare
arminru
reviewed
Oct 12, 2023
lmolkova
reviewed
Oct 12, 2023
lmolkova
approved these changes
Oct 12, 2023
…ocol-name-from-http-semconv
trask
force-pushed
the
remove-network-protocol-name-from-http-semconv
branch
from
633e0d2 to
936b074
Compare
trask
changed the title
network.protocol.name from HTTP semconv, effectively making it opt-innetwork.protocol.name from recommended to opt-in in the HTTP semconv
2 tasks
joaopgrassi
approved these changes
Oct 17, 2023
jsuereth
approved these changes
Oct 17, 2023
trask
added
the
ready-to-merge
reyang
approved these changes
Oct 18, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network.protocol.nameis typicallyhttp, so it doesn't provide much value to capture in HTTP semconv.Fixes #385
Changes
Changes
network.protocol.namefrom recommended to opt-in in the HTTP semconv.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.