Make server.port
conditionally required on HTTP server semconv
#399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #385
Changes
Makes
server.port
conditionally required on HTTP server semconv when it is not the default for the givenurl.scheme
(80/443).This avoids the question of whether missing
server.port
means default or unknown.And we expect
server.port
to be available to all HTTP server instrumentation.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.