Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Blog post for scaling OpenTelemetry Collectors using Ansible #4140

Closed
wants to merge 57 commits into from
Closed

Conversation

ishanjainn
Copy link
Contributor

@ishanjainn ishanjainn commented Mar 12, 2024

@ishanjainn ishanjainn requested a review from a team March 12, 2024 11:45
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few style guide suggestions. The Comms folks will make a more substantive review of the content.

content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the step numbering, as noted by @tiffany76, the indentation needs fixing:

image

Any content of a numbered list item should be indented by as many spaces as the number of characters before the first word of the item. (In your current format, that's 3 spaces, but if/when you fix the formatting, that might change.)

ishanjainn and others added 14 commits March 13, 2024 15:22
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, see my inline comments.

A lot of comments are around removing mention of "Grafana Cloud" in accordance with our Social Media Guide

content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
opentelemetrybot and others added 17 commits March 19, 2024 12:58
Co-authored-by: Jean Bisutti <[email protected]>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Phillip Carter <[email protected]>
… demo docs (#4142)

Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Phillip Carter <[email protected]>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Phillip Carter <[email protected]>
…4125)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Phillip Carter <[email protected]>
@ishanjainn ishanjainn requested review from a team and djaglowski and removed request for a team March 19, 2024 07:30
@ishanjainn
Copy link
Contributor Author

Ahh my bad, I think I messed up the Git commits way too much

@ishanjainn
Copy link
Contributor Author

ishanjainn commented Mar 19, 2024

closing this PR in favour of #4182
fyi @svrnm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.