Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Scaling OpenTelemetry Collectors using Ansible #4182

Merged
merged 41 commits into from
Apr 15, 2024
Merged

Blog: Scaling OpenTelemetry Collectors using Ansible #4182

merged 41 commits into from
Apr 15, 2024

Conversation

ishanjainn
Copy link
Contributor

@ishanjainn ishanjainn commented Mar 19, 2024

@ishanjainn
Copy link
Contributor Author

Hey @svrnm I closed the older PR for this

content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
@theletterf
Copy link
Member

@ishanjainn I've mixed feelings about this post. Half of the post is about Grafana while it claims to be about Ansible. Can we make it more specific to Ansible?

ishanjainn and others added 18 commits March 19, 2024 15:56
@ishanjainn
Copy link
Contributor Author

@ishanjainn I've mixed feelings about this post. Half of the post is about Grafana while it claims to be about Ansible. Can we make it more specific to Ansible

Hey thanks for the review! So the main point is to scale the collectors and only added Grafana (OSS) as the platform to view metrics as thats what seemed simplar. I just added clear steps to monitor in grafana as @svrnm suggested in my previous PR which I had to close

@theletterf
Copy link
Member

@svrnm @chalin

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, reads well. Thanks for the post @ishanjainn, and thanks for the first review pass @theletterf.

See inline for other suggested copyedits.

IMHO, the post fails to deliver the promise of the opening paragraph (for details, see my last review comment on the closing paragraph).

While my feedback may qualify as a tech-writer review, I'd prefer waiting for @svrnm and @cartermp to comment as well.

content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
content/en/blog/2024/scaling-opentelemetry-collectors.md Outdated Show resolved Hide resolved
@chalin chalin changed the title Blog: Blog post for scaling OpenTelemetry Collectors using Ansible Blog: Scaling OpenTelemetry Collectors using Ansible Apr 6, 2024
@svrnm
Copy link
Member

svrnm commented Apr 8, 2024

Thanks for the detailed review @chalin and apologies for not following up @ishanjainn, I was out of office for the last few weeks (including KubeCon). I think this is already in a good shape, if you can address @chalin's feedback we should be good, especially take a look at the comment around "delivering what the blog promises", this is a valid point that by fixing will make your blog signficiantly better.

@svrnm svrnm added the blog label Apr 8, 2024
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my site now, thanks for all the effort!

@chalin can you take a look into the open discussions and see if all your concerns are addressed?

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates.

@chalin
Copy link
Contributor

chalin commented Apr 12, 2024

/fix:all

Copy link
Contributor

@chalin
Copy link
Contributor

chalin commented Apr 12, 2024

You'll have a few linter and spelling issues to fix, but it should be good after that.

@svrnm
Copy link
Member

svrnm commented Apr 15, 2024

/fix:all

Copy link
Contributor

@svrnm
Copy link
Member

svrnm commented Apr 15, 2024

/fix:dict

Copy link
Contributor

@svrnm svrnm merged commit 97f51f4 into open-telemetry:main Apr 15, 2024
14 checks passed
@svrnm
Copy link
Member

svrnm commented Apr 15, 2024

@ishanjainn thanks for writing this up and working with us through the copy editing, your blog post is live now!

@ishanjainn
Copy link
Contributor Author

Hey @svrnm, If I wanted to add a meta image to the blog, Can I edit this in a PR and get that included too or that would not be possible to update now?

@svrnm
Copy link
Member

svrnm commented Apr 15, 2024

@ishanjainn create a new PR and we can merge that as follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants