-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog: Scaling OpenTelemetry Collectors using Ansible #4182
Conversation
Hey @svrnm I closed the older PR for this |
@ishanjainn I've mixed feelings about this post. Half of the post is about Grafana while it claims to be about Ansible. Can we make it more specific to Ansible? |
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Hey thanks for the review! So the main point is to scale the collectors and only added Grafana (OSS) as the platform to view metrics as thats what seemed simplar. I just added clear steps to monitor in grafana as @svrnm suggested in my previous PR which I had to close |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, reads well. Thanks for the post @ishanjainn, and thanks for the first review pass @theletterf.
See inline for other suggested copyedits.
IMHO, the post fails to deliver the promise of the opening paragraph (for details, see my last review comment on the closing paragraph).
While my feedback may qualify as a tech-writer review, I'd prefer waiting for @svrnm and @cartermp to comment as well.
Thanks for the detailed review @chalin and apologies for not following up @ishanjainn, I was out of office for the last few weeks (including KubeCon). I think this is already in a good shape, if you can address @chalin's feedback we should be good, especially take a look at the comment around "delivering what the blog promises", this is a valid point that by fixing will make your blog signficiantly better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from my site now, thanks for all the effort!
@chalin can you take a look into the open discussions and see if all your concerns are addressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8667719139 |
You'll have a few linter and spelling issues to fix, but it should be good after that. |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8686040782 |
/fix:dict |
You triggered fix:dict action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8686222218 |
@ishanjainn thanks for writing this up and working with us through the copy editing, your blog post is live now! |
Hey @svrnm, If I wanted to add a meta image to the blog, Can I edit this in a PR and get that included too or that would not be possible to update now? |
@ishanjainn create a new PR and we can merge that as follow up |
This continues #4140
Preview: https://deploy-preview-4182--opentelemetry.netlify.app/blog/2024/scaling-opentelemetry-collectors/