Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spring starter can now use all sdk autoconfig properties #4167

Merged
merged 11 commits into from
Mar 16, 2024
Merged

spring starter can now use all sdk autoconfig properties #4167

merged 11 commits into from
Mar 16, 2024

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Mar 15, 2024 •
edited
Loading

Also

  • annotation dependency is included in starter now
  • explain advanced config with the example of "exclude actuator endpoints from tracing"
  • explain resource providers

@zeitlinger zeitlinger self-assigned this Mar 15, 2024
@zeitlinger zeitlinger requested review from a team March 15, 2024 13:20
@zeitlinger zeitlinger mentioned this pull request Mar 15, 2024
Closed
5 tasks
@zeitlinger zeitlinger force-pushed the spring-sdk-autoconfig branch from a4d0161 to f4fac04 Compare March 15, 2024 16:25
@zeitlinger zeitlinger force-pushed the spring-sdk-autoconfig branch from f4fac04 to e504c25 Compare March 15, 2024 16:27
@zeitlinger zeitlinger mentioned this pull request Mar 15, 2024
Closed
@jeanbisutti
Copy link
Member

/fix:format

@github-actions GitHub Actions
Copy link
Contributor

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8301220049

theletterf
theletterf approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits. Thanks!

content/en/docs/languages/java/automatic/spring-boot.md Outdated

#### Tracer Properties
This style is convenient to use in environment variables:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This style is convenient to use in environment variables:
Use this style in environment variables:

content/en/docs/languages/java/automatic/spring-boot.md Outdated Show resolved Hide resolved
@jeanbisutti
Copy link
Member

/fix:format

@github-actions GitHub Actions
Copy link
Contributor

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/8302148725

@jeanbisutti
Copy link
Member

@theletterf Could you please have another look?

@theletterf
Copy link
Member

Approved!

@cartermp cartermp merged commit a904c3d into open-telemetry:main Mar 16, 2024
14 checks passed
@trask
Copy link
Member

trask commented Mar 27, 2024

I'm a little late, but this is great 🎉

@zeitlinger zeitlinger deleted the spring-sdk-autoconfig branch March 28, 2024 13:03
@zeitlinger
Copy link
Member Author

I'm a little late, but this is great 🎉

Never too late for that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@theletterf theletterf theletterf approved these changes

Assignees

@zeitlinger zeitlinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zeitlinger @jeanbisutti @theletterf @trask @cartermp @opentelemetrybot