-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic spec structure #4
Merged
iredelmeier
merged 1 commit into
open-telemetry:master
from
iredelmeier:add-basic-structure
May 6, 2019
Merged
Add basic spec structure #4
iredelmeier
merged 1 commit into
open-telemetry:master
from
iredelmeier:add-basic-structure
May 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iredelmeier
force-pushed
the
add-basic-structure
branch
from
May 4, 2019 00:21
6aac777
to
d24e385
Compare
austinlparker
approved these changes
May 6, 2019
SergeyKanzhelev
pushed a commit
that referenced
this pull request
Oct 28, 2019
* Update HTTP conventions. * Improve HTTP, fix references to peer.*. * Wording. * typo a/an http * host.name/host.port * Clarify server_name. * Typo, missing 'has'. * Typo nginx link. * Wording. * Typo in span name convention. Co-Authored-By: Tigran Najaryan <[email protected]> * Wording for common HTTP intro. In response to @SergeyKanzhelev (#263 (comment)). * Make http.flavor non-required. In-reply-to: #263 (comment) Co-authored-by: Sergey Kanzhelev <[email protected]> * Clarify client's http.url. In-reply-to: #263 (comment) * HTTP server span name: reference `http.app_root`. In-reply-to: #263 (comment) * Split "Definitions" from conventions, clarify app_root. In-reply-to: #263 (comment) * Qualify order of http server attr preferences. In-reply-to: #263 (comment) * Address review comments. * Typo. * Make http.status_code conditionally required. * Move http.host,target,scheme; clarify empty host. * Fix misplaced paragraph. * Fix client host/port requirement. * Fix HTTP status code OC incompat annotations. * Fix incomplete sentence. * Markdown syntax. * Update HTTP example (remove URL, add client). In-reply-to: #263 (comment) * Fix markdownlint. * Typo. * Remove http.app Span attribute. In-reply-to: #263 (comment) In-reply-to: #263 (comment) * Fix lint. ./specification/data-semantic-conventions.md:155: MD036 Emphasis used instead of a header * Add note about n:1 server_name + app_root => app. * Typo. * Remove http.app_root. (#4) In-reply-to: #263 (comment)
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Update HTTP conventions. * Improve HTTP, fix references to peer.*. * Wording. * typo a/an http * host.name/host.port * Clarify server_name. * Typo, missing 'has'. * Typo nginx link. * Wording. * Typo in span name convention. Co-Authored-By: Tigran Najaryan <[email protected]> * Wording for common HTTP intro. In response to @SergeyKanzhelev (open-telemetry#263 (comment)). * Make http.flavor non-required. In-reply-to: open-telemetry#263 (comment) Co-authored-by: Sergey Kanzhelev <[email protected]> * Clarify client's http.url. In-reply-to: open-telemetry#263 (comment) * HTTP server span name: reference `http.app_root`. In-reply-to: open-telemetry#263 (comment) * Split "Definitions" from conventions, clarify app_root. In-reply-to: open-telemetry#263 (comment) * Qualify order of http server attr preferences. In-reply-to: open-telemetry#263 (comment) * Address review comments. * Typo. * Make http.status_code conditionally required. * Move http.host,target,scheme; clarify empty host. * Fix misplaced paragraph. * Fix client host/port requirement. * Fix HTTP status code OC incompat annotations. * Fix incomplete sentence. * Markdown syntax. * Update HTTP example (remove URL, add client). In-reply-to: open-telemetry#263 (comment) * Fix markdownlint. * Typo. * Remove http.app Span attribute. In-reply-to: open-telemetry#263 (comment) In-reply-to: open-telemetry#263 (comment) * Fix lint. ./specification/data-semantic-conventions.md:155: MD036 Emphasis used instead of a header * Add note about n:1 server_name + app_root => app. * Typo. * Remove http.app_root. (open-telemetry#4) In-reply-to: open-telemetry#263 (comment)
TuckTuckFloof
pushed a commit
to TuckTuckFloof/opentelemetry-specification
that referenced
this pull request
Oct 15, 2020
rockb1017
pushed a commit
to rockb1017/opentelemetry-specification
that referenced
this pull request
Nov 18, 2021
Add initial repository specification
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 21, 2024
* Four metrics RFCs to eliminate raw statistics * Create 4 RFC drafts on metrics * Update 0001-metric-pre-defined-labels.md Co-Authored-By: Isobel Redelmeier <[email protected]> * Update 0001-metric-pre-defined-labels.md Co-Authored-By: Isobel Redelmeier <[email protected]> * Refinements * Set status to proposed * Assign numbers 3-4-5-6 * Renumber refs * Update status styling * Fix misspellings * Combine the first three into one
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 23, 2024
* Four metrics RFCs to eliminate raw statistics * Create 4 RFC drafts on metrics * Update 0001-metric-pre-defined-labels.md Co-Authored-By: Isobel Redelmeier <[email protected]> * Update 0001-metric-pre-defined-labels.md Co-Authored-By: Isobel Redelmeier <[email protected]> * Refinements * Set status to proposed * Assign numbers 3-4-5-6 * Renumber refs * Update status styling * Fix misspellings * Combine the first three into one
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Update HTTP conventions. * Improve HTTP, fix references to peer.*. * Wording. * typo a/an http * host.name/host.port * Clarify server_name. * Typo, missing 'has'. * Typo nginx link. * Wording. * Typo in span name convention. Co-Authored-By: Tigran Najaryan <[email protected]> * Wording for common HTTP intro. In response to @SergeyKanzhelev (open-telemetry#263 (comment)). * Make http.flavor non-required. In-reply-to: open-telemetry#263 (comment) Co-authored-by: Sergey Kanzhelev <[email protected]> * Clarify client's http.url. In-reply-to: open-telemetry#263 (comment) * HTTP server span name: reference `http.app_root`. In-reply-to: open-telemetry#263 (comment) * Split "Definitions" from conventions, clarify app_root. In-reply-to: open-telemetry#263 (comment) * Qualify order of http server attr preferences. In-reply-to: open-telemetry#263 (comment) * Address review comments. * Typo. * Make http.status_code conditionally required. * Move http.host,target,scheme; clarify empty host. * Fix misplaced paragraph. * Fix client host/port requirement. * Fix HTTP status code OC incompat annotations. * Fix incomplete sentence. * Markdown syntax. * Update HTTP example (remove URL, add client). In-reply-to: open-telemetry#263 (comment) * Fix markdownlint. * Typo. * Remove http.app Span attribute. In-reply-to: open-telemetry#263 (comment) In-reply-to: open-telemetry#263 (comment) * Fix lint. ./specification/data-semantic-conventions.md:155: MD036 Emphasis used instead of a header * Add note about n:1 server_name + app_root => app. * Typo. * Remove http.app_root. (open-telemetry#4) In-reply-to: open-telemetry#263 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some basic structure as well as an explanation of the structure, versioning, etc.