Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitespace (and other markdown-specific) linter for PRs #15

Closed
iredelmeier opened this issue May 20, 2019 · 6 comments
Closed

Add whitespace (and other markdown-specific) linter for PRs #15

iredelmeier opened this issue May 20, 2019 · 6 comments
Assignees

Comments

@iredelmeier
Copy link
Member

No description provided.

@tylerbenson
Copy link
Member

Perhaps we could at least start with an editorconfig file for all the projects to share?

@SergeyKanzhelev SergeyKanzhelev added this to the API complete milestone Jun 3, 2019
@SergeyKanzhelev SergeyKanzhelev modified the milestones: API proposal done, API revision: 07-2019 Jun 7, 2019
@SergeyKanzhelev SergeyKanzhelev changed the title Add whitespace linter for PRs Add whitespace (and other markdown-specific) linter for PRs Jun 15, 2019
@SergeyKanzhelev
Copy link
Member

Also from @iredelmeier on some PR:

General comment: having hard wraps in Markdown files makes editing, changing, and tracking history a lot harder than having only natural breaks at paragraph ends with soft wraps in editors :/ (Most Markdown viewers - GitHub's included - are able to handle this decently.)

This is one of those tabs vs. spaces discussions that we need to solve with the linter

@iredelmeier
Copy link
Member Author

Definitely, @SergeyKanzhelev.

I just came across markdownlint. Looks like it has support for some of what we want/might want, as well as the ability to add custom rules. Thoughts?

@arminru
Copy link
Member

arminru commented Jun 17, 2019

I'm using markdownlint as a VS Code plugin for my internal projects and found it to be working well so far. I've only been using the default config and didn't add any custom rules or enforce it in our CI yet, though.

@SergeyKanzhelev
Copy link
Member

I also use markdownlint for VSCode.

If it can be integrated with CI - it's great. As @yurishkuro suggested somewhere before - an option with the automatic formatter will make peoples life way better. Does mardownlint allows this? I believe Yuri was suggesting https://prettier.io/

@SergeyKanzhelev SergeyKanzhelev removed this from the API revision: 07-2019 milestone Sep 27, 2019
@SergeyKanzhelev
Copy link
Member

At one of the recent SIG meetings the decision was made to have a soft breaks for whitespaces rule. Also spell check is integrated now. If any other specific linters are required - please file a separate issues.

TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
rockb1017 pushed a commit to rockb1017/opentelemetry-specification that referenced this issue Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants