-
Notifications
You must be signed in to change notification settings - Fork 896
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enhance semantic conventions for HTTP (#263)
* Update HTTP conventions. * Improve HTTP, fix references to peer.*. * Wording. * typo a/an http * host.name/host.port * Clarify server_name. * Typo, missing 'has'. * Typo nginx link. * Wording. * Typo in span name convention. Co-Authored-By: Tigran Najaryan <[email protected]> * Wording for common HTTP intro. In response to @SergeyKanzhelev (#263 (comment)). * Make http.flavor non-required. In-reply-to: #263 (comment) Co-authored-by: Sergey Kanzhelev <[email protected]> * Clarify client's http.url. In-reply-to: #263 (comment) * HTTP server span name: reference `http.app_root`. In-reply-to: #263 (comment) * Split "Definitions" from conventions, clarify app_root. In-reply-to: #263 (comment) * Qualify order of http server attr preferences. In-reply-to: #263 (comment) * Address review comments. * Typo. * Make http.status_code conditionally required. * Move http.host,target,scheme; clarify empty host. * Fix misplaced paragraph. * Fix client host/port requirement. * Fix HTTP status code OC incompat annotations. * Fix incomplete sentence. * Markdown syntax. * Update HTTP example (remove URL, add client). In-reply-to: #263 (comment) * Fix markdownlint. * Typo. * Remove http.app Span attribute. In-reply-to: #263 (comment) In-reply-to: #263 (comment) * Fix lint. ./specification/data-semantic-conventions.md:155: MD036 Emphasis used instead of a header * Add note about n:1 server_name + app_root => app. * Typo. * Remove http.app_root. (#4) In-reply-to: #263 (comment)
- Loading branch information
1 parent
6e8fdd8
commit 2b8b767
Showing
1 changed file
with
209 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters