Use normative key words for Asynchronous and Synchronous API parameters #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Communicate the which parameters are absolute requirement for the Synchronous and Asynchronous instrument APIs to accept and the other parameters which are truly optional by using key words adopted by this specification and defined in BCP-14.
MrAlias
added
spec:metrics
jmacd
approved these changes
Jan 9, 2023
joaopgrassi
reviewed
Jan 13, 2023
Co-authored-by: Joao Grassi <[email protected]>
carlosalberto
approved these changes
Jan 16, 2023
jack-berg
reviewed
Jan 18, 2023
jack-berg
reviewed
Jan 18, 2023
tsloughter
reviewed
Jan 18, 2023
tsloughter
reviewed
Jan 18, 2023
Co-authored-by: Tristan Sloughter <[email protected]>
Co-authored-by: Tristan Sloughter <[email protected]>
pellared
reviewed
Jan 19, 2023
pellared
approved these changes
Jan 23, 2023
joaopgrassi
approved these changes
Jan 27, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…rs (open-telemetry#3074) * Use normative key words for inst API params Communicate the which parameters are absolute requirement for the Synchronous and Asynchronous instrument APIs to accept and the other parameters which are truly optional by using key words adopted by this specification and defined in BCP-14. * Update specification/metrics/api.md Co-authored-by: Joao Grassi <[email protected]> * Restructure based on PR feedback * Update specification/metrics/api.md Co-authored-by: Tristan Sloughter <[email protected]> * Update specification/metrics/api.md Co-authored-by: Tristan Sloughter <[email protected]> * Recommend no validation instead of requiring --------- Co-authored-by: Joao Grassi <[email protected]> Co-authored-by: Tristan Sloughter <[email protected]> Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Communicate the which parameters are absolute requirement for the Synchronous and Asynchronous instrument APIs to accept and the other parameters which are truly optional by using key words adopted by this specification and defined in BCP-14.