Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure logs bridge API doesn't contain implementation details #3275

Merged
merged 16 commits into from
Mar 27, 2023

Conversation

jack-berg
Copy link
Member

Contributes to #3268.

@MrAlias did some good work in the metrics API / SDK recently in #3171 and #3067 to ensure that the metrics API spec doesn't contain SDK implementation details.

This PR adopts similar language in the Logs Bridge API / SDK documents, which includes breaking out a noop.md document.

@jack-berg jack-berg requested review from a team March 2, 2023 20:08
@jack-berg jack-berg changed the title Ensure logs bridge API doesn't contain implemetnation details Ensure logs bridge API doesn't contain implementation details Mar 2, 2023
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jack-berg

specification/logs/bridge-api.md Outdated Show resolved Hide resolved
specification/logs/bridge-api.md Show resolved Hide resolved
specification/logs/bridge-api.md Outdated Show resolved Hide resolved
specification/logs/bridge-api.md Outdated Show resolved Hide resolved
specification/logs/bridge-api.md Outdated Show resolved Hide resolved
specification/logs/noop.md Outdated Show resolved Hide resolved
specification/logs/noop.md Outdated Show resolved Hide resolved
specification/logs/sdk.md Show resolved Hide resolved
specification/logs/sdk.md Outdated Show resolved Hide resolved
specification/logs/sdk.md Show resolved Hide resolved
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 11, 2023
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a specification structure perspective, and what we did w/ Metrics API, this LGTM

specification/logs/bridge-api.md Outdated Show resolved Hide resolved
specification/logs/noop.md Show resolved Hide resolved
@tigrannajaryan
Copy link
Member

@open-telemetry/specs-logs-approvers please review.

specification/logs/bridge-api.md Outdated Show resolved Hide resolved
specification/logs/bridge-api.md Show resolved Hide resolved
specification/logs/bridge-api.md Show resolved Hide resolved
@github-actions github-actions bot removed the Stale label Mar 24, 2023
@jack-berg jack-berg merged commit feabaab into open-telemetry:main Mar 27, 2023
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…elemetry#3275)

Contributes to open-telemetry#3268.

@MrAlias did some good work in the metrics API / SDK recently in open-telemetry#3171
and open-telemetry#3067 to ensure that the metrics API spec doesn't contain SDK
implementation details.

This PR adopts similar language in the Logs Bridge API / SDK documents,
which includes breaking out a `noop.md` document.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants