-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure logs bridge API doesn't contain implementation details #3275
Conversation
2983ba0
to
a31221e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jack-berg
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a specification structure perspective, and what we did w/ Metrics API, this LGTM
@open-telemetry/specs-logs-approvers please review. |
…elemetry#3275) Contributes to open-telemetry#3268. @MrAlias did some good work in the metrics API / SDK recently in open-telemetry#3171 and open-telemetry#3067 to ensure that the metrics API spec doesn't contain SDK implementation details. This PR adopts similar language in the Logs Bridge API / SDK documents, which includes breaking out a `noop.md` document.
Contributes to #3268.
@MrAlias did some good work in the metrics API / SDK recently in #3171 and #3067 to ensure that the metrics API spec doesn't contain SDK implementation details.
This PR adopts similar language in the Logs Bridge API / SDK documents, which includes breaking out a
noop.md
document.