Normatively define synchronous instrument record/add parameters #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Communicate the parameters for the instrument record/add APIs using normative key words adopted by this specification and defined in BCP-14.
MrAlias
added
spec:metrics
2 tasks
jmacd
approved these changes
Jan 9, 2023
pellared
reviewed
Jan 18, 2023
jack-berg
reviewed
Jan 18, 2023
Co-authored-by: jack-berg <[email protected]> Co-authored-by: Robert Pająk <[email protected]>
pellared
approved these changes
Jan 18, 2023
jack-berg
reviewed
Jan 18, 2023
Co-authored-by: Robert Pająk <[email protected]>
Feedback to these changes pointed out the original intent of the optional parameters is not to communicate the option for APIs, but for users to provide the values. Update the changes to match this intent.
Consistently use the same API identifier.
cijothomas
approved these changes
Jan 24, 2023
2 tasks
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…-telemetry#3082) * Normatively define sync inst record params Communicate the parameters for the instrument record/add APIs using normative key words adopted by this specification and defined in BCP-14. * Apply suggestions from code review Co-authored-by: jack-berg <[email protected]> Co-authored-by: Robert Pająk <[email protected]> * Update specification/metrics/api.md Co-authored-by: Robert Pająk <[email protected]> * Address feedback, all params required Feedback to these changes pointed out the original intent of the optional parameters is not to communicate the option for APIs, but for users to provide the values. Update the changes to match this intent. * This instead of the Consistently use the same API identifier. * Recommend no validation instead of requiring it --------- Co-authored-by: jack-berg <[email protected]> Co-authored-by: Robert Pająk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the parameters for the
AddAPI of theCounterandUpDownCounterand theRecordAPI of theHistogramare stated in non-normatively. Communicate these parameters for the instrument record/add APIs using normative key words adopted by this specification and defined in BCP-14.Fix #3081