Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is custom random generation a requirement for SDK or not? #34

Closed
SergeyKanzhelev opened this issue May 30, 2019 · 2 comments
Closed

Is custom random generation a requirement for SDK or not? #34

SergeyKanzhelev opened this issue May 30, 2019 · 2 comments
Labels
area:sdk Related to the SDK needs discussion Need more information before all suitable labels can be applied
Milestone
v0.3

Comments

@SergeyKanzhelev
Copy link
Member

See open-telemetry/opentelemetry-java#325.

The random generation of the Trace/Span id will be in the SDK. Main reason is that for example to support Amazon X-Ray the TraceID needs to be a specific format for example, also that is an implementation detail.

The question is whether it is a requirement for SDK to allow custom ID generators.
@SergeyKanzhelev
Copy link
Member Author

from @tedsuo - taking dependency on the format of TraceID is dangerous practice and we may want to discourage it. So making it a requirement to spec may not be desirable. Perhaps it can be optional feature.

@SergeyKanzhelev SergeyKanzhelev added this to the SDK complete milestone Jun 3, 2019
@SergeyKanzhelev SergeyKanzhelev added area:sdk Related to the SDK and removed area:sdk Related to the SDK labels Jun 21, 2019
@iredelmeier iredelmeier added the needs discussion Need more information before all suitable labels can be applied label Jul 30, 2019
@SergeyKanzhelev SergeyKanzhelev modified the milestones: SDK proposal complete, Alpha v0.3 Sep 27, 2019
@jmacd
Copy link
Contributor

jmacd commented Jan 22, 2020

We believe this is not a requirement, now that the sampling hint has been removed from the API. An SDK is free to use its own generator.

@jmacd jmacd closed this as completed Jan 22, 2020
@kowshikn kowshikn mentioned this issue Sep 17, 2020
Merged
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
@g-easy
Run benchmarks on CI. (open-telemetry#34)
573696f
@lmolkova lmolkova mentioned this issue Jun 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:sdk Related to the SDK needs discussion Need more information before all suitable labels can be applied
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
3 participants
@iredelmeier @jmacd @SergeyKanzhelev