Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpanId/TraceId generation #325

Closed
carlosalberto opened this issue May 17, 2019 · 5 comments
Closed

SpanId/TraceId generation #325

carlosalberto opened this issue May 17, 2019 · 5 comments
Assignees
Labels
Agreed Issues that the group agreed on. API API related issues

Comments

@carlosalberto
Copy link
Contributor

While testing out the testbed for the OT Shim (and its related in-memory Tracer), I realized that random generation of SpanId and TraceId is gone (it's part of the main API in OC).

Any reason to truly remove it, other than reducing the exposed API? That being said, I'd like to at least have access to something like SpanId.create(long).

@bogdandrutu
Copy link
Member

The random generation of the Trace/Span id will be in the SDK. Main reason is that for example to support Amazon X-Ray the TraceID needs to be a specific format for example, also that is an implementation detail.

@carlosalberto
Copy link
Contributor Author

I'm wondering if it would be helpful to expose the constructors, nevertheless - otherwise, user will most likely have to use UUID + string manipulation to pass a byte [] to SpanId/TraceId to create new ids ;)

@carlosalberto
Copy link
Contributor Author

Hey @bogdandrutu any opinion on this last comment? If you really think we don't need this, lets close this Issue (and perhaps discuss it in the future if/as needed)

@tedsuo
Copy link
Contributor

tedsuo commented May 30, 2019

If TraceID() and SanID() generators are on the Tracer interface, we can defer the the implementation's choice of ID schemes.

@tedsuo
Copy link
Contributor

tedsuo commented Jun 6, 2019

For now, we are going to keep these methods private/protected, as we know we need to support customer TraceID's in the future (AWS xray, etc).

@tedsuo tedsuo added the Agreed Issues that the group agreed on. label Jun 6, 2019
@tedsuo tedsuo closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agreed Issues that the group agreed on. API API related issues
Projects
None yet
Development

No branches or pull requests

4 participants