This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Initial commit of service map stateful processor plugin #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowshikn
suggested changes
Sep 14, 2020
...ce-map-stateful/src/main/java/com/amazon/situp/plugins/processor/ServiceMapRelationship.java
Show resolved
Hide resolved
...ce-map-stateful/src/main/java/com/amazon/situp/plugins/processor/ServiceMapRelationship.java
Outdated
Show resolved
Hide resolved
...p-stateful/src/main/java/com/amazon/situp/plugins/processor/ServiceMapStatefulProcessor.java
Outdated
Show resolved
Hide resolved
AustinTag
commented
Sep 17, 2020
...ocessor-state/src/main/java/com/amazon/situp/plugins/processor/state/LmdbProcessorState.java
Outdated
Show resolved
Hide resolved
erosas
reviewed
Sep 17, 2020
...p-stateful/src/main/java/com/amazon/situp/plugins/processor/ServiceMapStatefulProcessor.java
Outdated
Show resolved
Hide resolved
...p-stateful/src/main/java/com/amazon/situp/plugins/processor/ServiceMapStatefulProcessor.java
Outdated
Show resolved
Hide resolved
...p-stateful/src/main/java/com/amazon/situp/plugins/processor/ServiceMapStatefulProcessor.java
Outdated
Show resolved
Hide resolved
kowshikn
reviewed
Sep 17, 2020
...p-stateful/src/main/java/com/amazon/situp/plugins/processor/ServiceMapStatefulProcessor.java
Show resolved
Hide resolved
...p-stateful/src/main/java/com/amazon/situp/plugins/processor/ServiceMapStatefulProcessor.java
Outdated
Show resolved
Hide resolved
.../service-map-stateful/src/main/java/com/amazon/situp/plugins/processor/KeyRangeSplitter.java
Outdated
Show resolved
Hide resolved
...p-stateful/src/main/java/com/amazon/situp/plugins/processor/ServiceMapStatefulProcessor.java
Show resolved
Hide resolved
...ocessor-state/src/main/java/com/amazon/situp/plugins/processor/state/LmdbProcessorState.java
Show resolved
Hide resolved
kowshikn
reviewed
Sep 21, 2020
kowshikn
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for the first revision. Just one thought,
//TODO: Look into faster way to move cursor up N elements
for(long i=0; i<start; i++) {
cursor.next();
}
If we can not optimize this we should do the whole scan and find keyranges once rather than each processor's iterate doing it.
erosas
reviewed
Sep 21, 2020
...ocessor-state/src/main/java/com/amazon/situp/plugins/processor/state/LmdbProcessorState.java
Show resolved
Hide resolved
erosas
approved these changes
Sep 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding initial commit of stateful service map processor plugin
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.