-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flush exception thrown when LoggerProvider not configured #3608
Merged
ocelotl
merged 3 commits into
open-telemetry:main
from
iurisilvio:fix-noop-logger-force-flush
Feb 14, 2024
Merged
Fix flush exception thrown when LoggerProvider not configured #3608
ocelotl
merged 3 commits into
open-telemetry:main
from
iurisilvio:fix-noop-logger-force-flush
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iurisilvio
force-pushed
the
fix-noop-logger-force-flush
branch
from
January 1, 2024 09:40
d14f51f
to
853bd75
Compare
mrj0
reviewed
Jan 3, 2024
iurisilvio
force-pushed
the
fix-noop-logger-force-flush
branch
2 times, most recently
from
January 9, 2024 22:48
4abb135
to
2fe915e
Compare
pmcollins
reviewed
Jan 9, 2024
opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
iurisilvio
force-pushed
the
fix-noop-logger-force-flush
branch
from
January 19, 2024 13:29
0f04e76
to
3a3ea44
Compare
pmcollins
reviewed
Jan 19, 2024
srikanthccv
approved these changes
Jan 20, 2024
ocelotl
force-pushed
the
fix-noop-logger-force-flush
branch
from
February 14, 2024 18:28
3a3ea44
to
1ddd505
Compare
This test case passes but it is hiding an error:
|
ocelotl
approved these changes
Feb 14, 2024
iurisilvio
commented
Feb 14, 2024
auto-merge was automatically disabled
February 14, 2024 19:46
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found #3423 fixing a similar issue and reused most of the idea. I preferred to write a test using the proper spec
NoOpLoggerProvider
instead of using the genericLogProvider
and mocking theforce_flush
method.I checked for other uses of
logger_provider
but didn't find any.Fixes #3602
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist:
Happy new year! 🎉 🎆 🍰