Fix flush exception thrown when LoggerProvider not configured

open-telemetry · Jan 1, 2024 · d14f51f · d14f51f
1 parent da48e0b
commit d14f51f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
@@ -543,9 +543,10 @@ def emit(self, record: logging.LogRecord) -> None:
 
     def flush(self) -> None:
         """
-        Flushes the logging output.
+        Flushes the logging output. Skip flushing if logger is NoOp.
         """
-        self._logger_provider.force_flush()
+        if not isinstance(self._logger, NoOpLogger):
+            self._logger_provider.force_flush()
 
 
 class Logger(APILogger):

diff --git a/opentelemetry-sdk/tests/logs/test_handler.py b/opentelemetry-sdk/tests/logs/test_handler.py
@@ -79,6 +79,12 @@ def test_log_record_emit_noop(self):
             logger.warning("Warning message")
         handler_mock._translate.assert_not_called()
 
+    def test_log_flush_noop(self):
+        emitter_provider_mock = Mock(spec=NoOpLoggerProvider)
+        logger = get_logger(logger_provider=emitter_provider_mock)
+        with self.assertLogs(level=logging.WARNING):
+            logger.warning("Warning message")
+
     def test_log_record_no_span_context(self):
         emitter_provider_mock = Mock(spec=LoggerProvider)
         emitter_mock = APIGetLogger(