fixup! Fix flush exception thrown when LoggerProvider not configured

open-telemetry · Jan 9, 2024 · 2fe915e · 2fe915e
1 parent 3a3ea44
commit 2fe915e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py b/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
@@ -151,6 +151,9 @@ def get_logger(
             schema_url: Optional. Specifies the Schema URL of the emitted telemetry.
         """
 
+    def force_flush(self) -> None:
+        pass
+
 
 class NoOpLoggerProvider(LoggerProvider):
     """The default LoggerProvider used when no LoggerProvider implementation is available."""

diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
@@ -543,10 +543,9 @@ def emit(self, record: logging.LogRecord) -> None:
 
     def flush(self) -> None:
         """
-        Flushes the logging output. Skip flushing if logger is NoOp.
+        Flushes the logging output.
         """
-        if not isinstance(self._logger, NoOpLogger):
-            self._logger_provider.force_flush()
+        self._logger_provider.force_flush()
 
 
 class Logger(APILogger):