Remove unused properties in exceptions for request instrumentation #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
requested review from
a team,
owais and
ocelotl
and removed request for
a team
codeboten
reviewed
Nov 23, 2020
| @@ -158,9 +154,6 @@ def _instrumented_requests_call( | |||
| result = call_wrapped() # *** PROCEED | |||
| except Exception as exc: # pylint: disable=W0703 | |||
| exception = exc | |||
| setattr( | |||
| exception, EXCEPTION_STATUS_FIELD, StatusCode.ERROR, | |||
| ) | |||
There was a problem hiding this comment.
Can you explain a bit more about why this is being removed or why this was here in the first place?
There was a problem hiding this comment.
I believe from this pr, the purpose was get the status code that was returned from a failed instrumentation, but now since we don't track statuscanonicalcode anymore, we don't need this.
codeboten
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-telemetry/opentelemetry-python#1301