Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-release] Update changelogs, version [0.16b0] #204

Closed
wants to merge 5 commits into from

Conversation

codeboten
Copy link
Contributor

preparing 0.16b0 release

@codeboten codeboten requested review from a team, toumorokoshi and aabmass and removed request for a team November 23, 2020 17:12
Copy link
Contributor

@NathanielRN NathanielRN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :) Just some small comments!

publish:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used v1 yet, every time I've used this it's uses: actions/checkout@v2 as in test.yml! Might as well use a newer version? (if that's what this means).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be updated, but i just used what was already there in the core repo.

- uses: actions/checkout@v1
- uses: actions/setup-python@v1
with:
python-version: '3.7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with Python 3.7, but just wondering if there's a reason why it can't be 3.8 or 3.9?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason. This is a straight copy of the publish action in the core repo

.github/workflows/publish.yml Outdated Show resolved Hide resolved
Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <[email protected]>
@NathanielRN
Copy link
Contributor

NathanielRN commented Nov 24, 2020

Since there were updates to the Contrib & Core repo (specifically #190):

will fix the tests on the Core repo PR: https://github.com/open-telemetry/opentelemetry-python/runs/1449182101?check_suite_focus=true

@codeboten codeboten closed this Nov 24, 2020
@codeboten codeboten deleted the release/0.16b0-auto branch November 24, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants