Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused properties in exceptions for request instrumentation #190

Merged
merged 3 commits into from
Nov 23, 2020
+1 −8
Merged

Remove unused properties in exceptions for request instrumentation #190

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec81ffb
req
lzchen Nov 17, 2020
848cad8
Merge branch 'master' into req
lzchen Nov 23, 2020
9ad88e1
Merge branch 'master' into req
lzchen Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions ...telemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,7 @@
from opentelemetry.instrumentation.requests.version import __version__
from opentelemetry.instrumentation.utils import http_status_to_status_code
from opentelemetry.trace import SpanKind, get_tracer
from opentelemetry.trace.status import (
EXCEPTION_STATUS_FIELD,
Status,
StatusCode,
)
from opentelemetry.trace.status import Status, StatusCode

# A key to a context variable to avoid creating duplicate spans when instrumenting
# both, Session.request and Session.send, since Session.request calls into Session.send
Expand Down Expand Up @@ -158,9 +154,6 @@ def _instrumented_requests_call(
result = call_wrapped() # *** PROCEED
except Exception as exc: # pylint: disable=W0703
exception = exc
setattr(
exception, EXCEPTION_STATUS_FIELD, StatusCode.ERROR,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit more about why this is being removed or why this was here in the first place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe from this pr, the purpose was get the status code that was returned from a failed instrumentation, but now since we don't track statuscanonicalcode anymore, we don't need this.

result = getattr(exc, "response", None)
finally:
context.detach(token)
Expand Down