Fixed Otel Controller - Auxiliares resources deletion #2575

yuriolisa · 2024-01-29T15:28:08Z

Description:

Fixed HPA deletion
Link to tracking Issue:
Resolves #2568
Resolves #2651
Resolves #2587

Testing:
Added new e2e test to check this step.
Documentation:

Created a new bundle due to the new RBAC for PersistentVolumes and PersistentVolumesClaims.
Fixed the labels used by Ingress resources and their unit tests.
Created new function findOtelOwnedObjects which will find all the owned objects and serve as an auxiliary resource to the reconcileDesiredObjects function to keep or delete the expected objects.
Changed the parameters of the function HorizontalPodAutoscaler from client.Object to *autoscalingv2.HorizontalPodAutoscaler to keep the same pattern we have been using for another resources.
Added the networkv1 package to the scheme. (networkingv1.AddToScheme(scheme)).
Update Chainsaw from 0.1.4 to 0.1.7 in order to get the patch operation enabled.
Created new e2e tests for Ingress and HorizontalPodAutoscalers to test the deletion process.
Added the testdata.ServiceMonitorCRD, testdata.PodMonitorCRD to the controllers/suite_test.go

Signed-off-by: Yuri Sa <[email protected]>

internal/manifests/collector/horizontalpodautoscaler.go

Signed-off-by: Yuri Sa <[email protected]>

jaronoff97

Looking great! Thank you for implementing this.

controllers/opentelemetrycollector_controller.go

tests/e2e-autoscale/autoscale/04-error.yaml

controllers/common.go

Signed-off-by: Yuri Sa <[email protected]>

jaronoff97

one comment. Otherwise, were you able to confirm locally that this does as we intend?

controllers/common.go

Signed-off-by: Yuri Sa <[email protected]>

controllers/common.go

Signed-off-by: Yuri Sa <[email protected]>

tests/e2e-autoscale/autoscale/04-delete.yaml

Signed-off-by: Yuri Sa <[email protected]>

controllers/suite_test.go

Signed-off-by: Yuri Sa <[email protected]>

jaronoff97

just two small things, otherwise this LGTM!! Thank you so much Yuri.

controllers/common.go

Signed-off-by: Yuri Sa <[email protected]>

pavolloffay · 2024-02-26T13:56:01Z

The CI is still failing :/

jaronoff97

looks like it's failing on: error listing ServiceMonitors: no kind is registered for the type v1.ServiceMonitorList in scheme "pkg/runtime/scheme.go:100"

Overall though i think this looks good to me!

Signed-off-by: Yuri Sa <[email protected]>

Add a sleep to the tests

Signed-off-by: Yuri Sa <[email protected]>

pavolloffay · 2024-02-28T15:31:35Z

Still one e2e test is failing

Signed-off-by: Yuri Sa <[email protected]>

Makefile

Signed-off-by: Yuri Sa <[email protected]>

jaronoff97 · 2024-02-28T18:42:15Z

@yuriolisa thank you so much for your heroics here. I really appreciate the work and all the fixes that come from this.

…#2575) * Fixed HPA deletion Signed-off-by: Yuri Sa <[email protected]> * Fix e2e tests Signed-off-by: Yuri Sa <[email protected]> * Added reconciliation test Signed-off-by: Yuri Sa <[email protected]> * Added owned objects function Signed-off-by: Yuri Sa <[email protected]> * Fixed controller test Signed-off-by: Yuri Sa <[email protected]> * Fixed controller test Signed-off-by: Yuri Sa <[email protected]> * Fixed controller test Signed-off-by: Yuri Sa <[email protected]> * Add PodDisruptionBudget Signed-off-by: Yuri Sa <[email protected]> * Change vars setting Signed-off-by: Yuri Sa <[email protected]> * Change vars setting Signed-off-by: Yuri Sa <[email protected]> * Update e2e tests to chainsaw Signed-off-by: Yuri Sa <[email protected]> * Added ingress e2e tests Signed-off-by: Yuri Sa <[email protected]> * Added Volumes, changed function's place Signed-off-by: Yuri Sa <[email protected]> * Added Volumes, changed function's place Signed-off-by: Yuri Sa <[email protected]> * Added Volumes, changed function's place Signed-off-by: Yuri Sa <[email protected]> * Fixed Suite Test Signed-off-by: Yuri Sa <[email protected]> * Added RBAC for Volumes Signed-off-by: Yuri Sa <[email protected]> * Added RBAC for Volumes Signed-off-by: Yuri Sa <[email protected]> * Fixed Suite Test Signed-off-by: Yuri Sa <[email protected]> * Fixed Suite Test Signed-off-by: Yuri Sa <[email protected]> * Fixed Suite Test Signed-off-by: Yuri Sa <[email protected]> * Add a sleep * Fixed Chainsaw test Signed-off-by: Yuri Sa <[email protected]> * Fixed Chainsaw test Signed-off-by: Yuri Sa <[email protected]> * Fixed Chainsaw test Signed-off-by: Yuri Sa <[email protected]> * Fixed Chainsaw test Signed-off-by: Yuri Sa <[email protected]> --------- Signed-off-by: Yuri Sa <[email protected]> Co-authored-by: Jacob Aronoff <[email protected]>

Fixed HPA deletion

5a31481

Signed-off-by: Yuri Sa <[email protected]>

yuriolisa requested a review from a team January 29, 2024 15:28

Fix e2e tests

bd9bd93

Signed-off-by: Yuri Sa <[email protected]>

swiatekm approved these changes Jan 29, 2024

View reviewed changes

jaronoff97 reviewed Jan 29, 2024

View reviewed changes

internal/manifests/collector/horizontalpodautoscaler.go Outdated Show resolved Hide resolved

yuriolisa added 6 commits February 12, 2024 12:13

Added reconciliation test

10f82b0

Signed-off-by: Yuri Sa <[email protected]>

Changed from client.Object to HPA Obj

515a034

Signed-off-by: Yuri Sa <[email protected]>

Added owned objects function

2ac2af7

Signed-off-by: Yuri Sa <[email protected]>

Fixed controller test

a61de02

Signed-off-by: Yuri Sa <[email protected]>

Fixed controller test

20c7bf6

Signed-off-by: Yuri Sa <[email protected]>

Fixed controller test

29135cd

Signed-off-by: Yuri Sa <[email protected]>

jaronoff97 reviewed Feb 13, 2024

View reviewed changes

controllers/opentelemetrycollector_controller.go Show resolved Hide resolved

tests/e2e-autoscale/autoscale/04-error.yaml Show resolved Hide resolved

controllers/common.go Outdated Show resolved Hide resolved

controllers/common.go Outdated Show resolved Hide resolved

Add PodDisruptionBudget

8f6159c

Signed-off-by: Yuri Sa <[email protected]>

jaronoff97 reviewed Feb 14, 2024

View reviewed changes

controllers/common.go Outdated Show resolved Hide resolved

Add PodDisruptionBudget

dacc99a

Signed-off-by: Yuri Sa <[email protected]>

jaronoff97 requested a review from frzifus February 15, 2024 18:44

pavolloffay reviewed Feb 16, 2024

View reviewed changes

controllers/common.go Outdated Show resolved Hide resolved

controllers/common.go Outdated Show resolved Hide resolved

yuriolisa added 3 commits February 16, 2024 13:37

Change vars setting

a0a30da

Signed-off-by: Yuri Sa <[email protected]>

Change vars setting

1edd721

Signed-off-by: Yuri Sa <[email protected]>

Change vars setting

29ad837

Signed-off-by: Yuri Sa <[email protected]>

yuriolisa requested a review from pavolloffay February 19, 2024 13:23

jaronoff97 reviewed Feb 19, 2024

View reviewed changes

tests/e2e-autoscale/autoscale/04-delete.yaml Outdated Show resolved Hide resolved

jaronoff97 mentioned this pull request Feb 20, 2024

Disabling ingress does not remove the created ingress objects #2651

Closed

Update e2e tests to chainsaw

2f1b576

Signed-off-by: Yuri Sa <[email protected]>

yuriolisa changed the title ~~Fixed HPA deletion~~ Fixed Otel Controller - Auxiliares resources deletion Feb 20, 2024

swiatekm self-requested a review February 20, 2024 16:48

jaronoff97 reviewed Feb 20, 2024

View reviewed changes

controllers/suite_test.go Outdated Show resolved Hide resolved

Added ingress e2e tests

9a669d0

Signed-off-by: Yuri Sa <[email protected]>

jaronoff97 reviewed Feb 21, 2024

View reviewed changes

controllers/common.go Outdated Show resolved Hide resolved

controllers/common.go Outdated Show resolved Hide resolved

Added Volumes, changed function's place

ebbb447

Signed-off-by: Yuri Sa <[email protected]>

pavolloffay approved these changes Feb 26, 2024

View reviewed changes

jaronoff97 approved these changes Feb 26, 2024

View reviewed changes

yuriolisa and others added 11 commits February 26, 2024 19:37

Added Volumes, changed function's place

55240ba

Signed-off-by: Yuri Sa <[email protected]>

Added Volumes, changed function's place

4350a56

Signed-off-by: Yuri Sa <[email protected]>

Fixed Suite Test

1839504

Signed-off-by: Yuri Sa <[email protected]>

Added RBAC for Volumes

88b30ef

Signed-off-by: Yuri Sa <[email protected]>

Added RBAC for Volumes

7e1b010

Signed-off-by: Yuri Sa <[email protected]>

Fixed Suite Test

18c8385

Signed-off-by: Yuri Sa <[email protected]>

Fixed Suite Test

3e77e72

Signed-off-by: Yuri Sa <[email protected]>

Fixed Suite Test

8bd21d5

Signed-off-by: Yuri Sa <[email protected]>

Add a sleep

2087366

Merge pull request #1 from jaronoff97/fix-hpa-delete

d2a0269

Add a sleep to the tests

Fixed Chainsaw test

7d09dd0

Signed-off-by: Yuri Sa <[email protected]>

Fixed Chainsaw test

42469b4

Signed-off-by: Yuri Sa <[email protected]>

swiatekm reviewed Feb 28, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

yuriolisa added 3 commits February 28, 2024 17:44

Fixed Chainsaw test

8af8038

Signed-off-by: Yuri Sa <[email protected]>

Fixed Chainsaw test

1ffc7eb

Signed-off-by: Yuri Sa <[email protected]>

Fixed Chainsaw test

ba7c3b2

Signed-off-by: Yuri Sa <[email protected]>

jaronoff97 approved these changes Feb 28, 2024

View reviewed changes

jaronoff97 merged commit 874c72a into open-telemetry:main Feb 28, 2024
29 checks passed

swiatekm mentioned this pull request Mar 4, 2024

Bump operator to 0.95.0 open-telemetry/opentelemetry-helm-charts#1062

Merged

iblancasa mentioned this pull request Jul 3, 2024

Don't unnecessarily take ownership of PersistentVolumes and PersistentVolumeClaims #3097

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed Otel Controller - Auxiliares resources deletion #2575

Fixed Otel Controller - Auxiliares resources deletion #2575

yuriolisa commented Jan 29, 2024 •

edited

Loading

jaronoff97 left a comment

jaronoff97 left a comment

jaronoff97 left a comment

pavolloffay commented Feb 26, 2024

jaronoff97 left a comment

pavolloffay commented Feb 28, 2024

jaronoff97 commented Feb 28, 2024

Fixed Otel Controller - Auxiliares resources deletion #2575

Fixed Otel Controller - Auxiliares resources deletion #2575

Conversation

yuriolisa commented Jan 29, 2024 • edited Loading

jaronoff97 left a comment

Choose a reason for hiding this comment

jaronoff97 left a comment

Choose a reason for hiding this comment

jaronoff97 left a comment

Choose a reason for hiding this comment

pavolloffay commented Feb 26, 2024

jaronoff97 left a comment

Choose a reason for hiding this comment

pavolloffay commented Feb 28, 2024

jaronoff97 commented Feb 28, 2024

yuriolisa commented Jan 29, 2024 •

edited

Loading