Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump operator to 0.95.0 #1062

Merged

Conversation

swiatekm
Copy link
Contributor

@swiatekm swiatekm commented Mar 4, 2024

Part of open-telemetry/opentelemetry-operator#2656

I had to add new permissions to the operator ClusterRole due to open-telemetry/opentelemetry-operator#2575. I ended up copying the rules from the operator's kustomize manifest, resulting in a smaller ClusterRole at the end of it.

@swiatekm swiatekm force-pushed the chore/upgrade-operator-0950 branch from 12ae242 to 6f3315f Compare March 4, 2024 17:34
@swiatekm swiatekm marked this pull request as ready for review March 4, 2024 17:50
@swiatekm swiatekm requested a review from Allex1 as a code owner March 4, 2024 17:50
@swiatekm swiatekm requested a review from a team March 4, 2024 17:50
@Allex1
Copy link
Contributor

Allex1 commented Mar 6, 2024

@swiatekm-sumo I think the cluster role needs to be identical to https://github.com/open-telemetry/opentelemetry-operator/blob/main/config/rbac/role.yaml. Also we had some tests for the roles.

@swiatekm swiatekm force-pushed the chore/upgrade-operator-0950 branch 2 times, most recently from b555d36 to 57866d0 Compare March 6, 2024 14:30
@swiatekm
Copy link
Contributor Author

swiatekm commented Mar 6, 2024

@swiatekm-sumo I think the cluster role needs to be identical to https://github.com/open-telemetry/opentelemetry-operator/blob/main/config/rbac/role.yaml. Also we had some tests for the roles.

It is identical, just formatted differently. I copied it from the operator, and then chart tooling reformatted it.

Add CRUD permission for PersistentVolume and PersistentVolumeClaim.
@swiatekm swiatekm force-pushed the chore/upgrade-operator-0950 branch from 57866d0 to eb1e153 Compare March 11, 2024 11:10
@swiatekm
Copy link
Contributor Author

@Allex1 can we merge this? Operator 0.96.0 is going to be out very soon.

@TylerHelmuth TylerHelmuth merged commit f7e4da7 into open-telemetry:main Mar 11, 2024
3 checks passed
@swiatekm swiatekm deleted the chore/upgrade-operator-0950 branch March 12, 2024 10:14
12ushan pushed a commit to giffgaff/opentelemetry-helm-charts that referenced this pull request Jul 22, 2024
* Bump operator to 0.95.0

* Bump chainsaw to 0.1.7

* Update otel operator CluterRole

Add CRUD permission for PersistentVolume and PersistentVolumeClaim.

---------

Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants