Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't unnecessarily take ownership of PersistentVolumes and PersistentVolumeClaims #3097

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

swiatekm
Copy link
Contributor

@swiatekm swiatekm commented Jul 3, 2024

Description:
Fixed a bug where we'd unnecessarily watch PVs and PVCs without ever creating any. For mysterious reasons, this caused issues when running the operator scoped to a single namespace, using a Role for RBAC. See #3042.

Link to tracking Issue(s): #3042

@swiatekm swiatekm requested a review from a team July 3, 2024 10:28
Copy link
Contributor

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added here #2575

Because of this: #2587

Are we sure we can remove this without any implications?

@swiatekm
Copy link
Contributor Author

swiatekm commented Jul 3, 2024

@yuriolisa can you have a look as the author of #2575? It doesn't look like we're actually deleting PVCs left after deleting a StatefulSet, nor do I think we should be.

Copy link
Contributor

@yuriolisa yuriolisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…tVolumeClaims

# Conflicts:
#	bundle/openshift/manifests/opentelemetry-operator.clusterserviceversion.yaml
@swiatekm swiatekm force-pushed the fix/dont-own-volumes branch from d40c93e to 8679a4a Compare August 27, 2024 07:27
@swiatekm swiatekm merged commit a1e8f92 into open-telemetry:main Aug 27, 2024
33 checks passed
@swiatekm swiatekm deleted the fix/dont-own-volumes branch August 27, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants