[chore] Refactor platform to be openshift routes availability #1463
Conversation
Signed-off-by: Israel Blancas <[email protected]>
|
@iblancasa could you remove the [chore] in the title and add a changelog entry please? this seems to be a bit more than a minor version upgrade / test fix. |
Signed-off-by: Israel Blancas <[email protected]>
iblancasa
changed the title
| component: operator | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: "Change the platform detection to be API detection. Previously, the operator was checking the plaform where it was running -OpenShift or Kubernetes-. Now, we just check if the OpenShift Route API is enabled" |
There was a problem hiding this comment.
| note: "Change the platform detection to be API detection. Previously, the operator was checking the plaform where it was running -OpenShift or Kubernetes-. Now, we just check if the OpenShift Route API is enabled" | |
| note: "Change the platform detection to be API detection. Previously, the operator was checking the plaform where it was running OpenShift or Kubernetes. Now, we just check if the OpenShift Route API is enabled" |
There was a problem hiding this comment.
I think this change lefts the sentence with a different meaning or not well written. I would prefer to keep how it was written
There was a problem hiding this comment.
This does not need to be in the changelog. it's an internal refactoring.
| component: operator | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: "Change the platform detection to be API detection. Previously, the operator was checking the plaform where it was running -OpenShift or Kubernetes-. Now, we just check if the OpenShift Route API is enabled" |
There was a problem hiding this comment.
This does not need to be in the changelog. it's an internal refactoring.
@jaronoff97 do we need to add a changelog for these "internal" changes? |
|
The code is exposed, but I think we should consider making most of the packages internal as they were not designed to be imported externally. |
Signed-off-by: Israel Blancas <[email protected]>
|
@pavolloffay I agree, if these were internal only, i don't think the changelog would be necessary. Given these have the potential to be used externally right now, I was thinking it would be valuable to have the entry. |
Signed-off-by: Israel Blancas <[email protected]>
iblancasa
changed the title
|
Changelog removed |
…or into fix/1418 Signed-off-by: Israel Blancas <[email protected]>
…elemetry#1463) * Refactor platform to be openshift routes availability * Add minor changes asked in code review Signed-off-by: Israel Blancas <[email protected]> * Add changelog Signed-off-by: Israel Blancas <[email protected]> * Rename method Signed-off-by: Israel Blancas <[email protected]> * Delete changelog as is not needed Signed-off-by: Israel Blancas <[email protected]> --------- Signed-off-by: Israel Blancas <[email protected]>
Closes #1418.
Replace the OpenShift platform detection with OpenShift Routes API detection.