You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While checking the problem described in #1418, we found the autodetection for HPA is not 100% correct.
The configuration is set as a value in the autoDetect struct (internal/config/main.go). So, if we copy an instance of the Config struct (like passing it by value in a method) and update the copy (from a different Goroutine for instance), the HPA value will not be reflected in the copy. This problem was solved previously for other components from Autodetect (#1206 (comment)).
To solve this problem, we can follow the same approach done for OpenShift Routes in #1463.
So, for instance, in the (c *Config) AutoDetect method, instead of:
While checking the problem described in #1418, we found the autodetection for HPA is not 100% correct.
The configuration is set as a value in the
autoDetect
struct (internal/config/main.go
). So, if we copy an instance of theConfig
struct (like passing it by value in a method) and update the copy (from a different Goroutine for instance), the HPA value will not be reflected in the copy. This problem was solved previously for other components fromAutodetect
(#1206 (comment)).To solve this problem, we can follow the same approach done for OpenShift Routes in #1463.
So, for instance, in the
(c *Config) AutoDetect
method, instead of:We should do the same as we do for the OpenShift Routes:
The text was updated successfully, but these errors were encountered: