Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the autodetect platform logic by something that express in a clearer way that OpenShift Routes are available instead of the Platform used #1418

Closed
iblancasa opened this issue Feb 1, 2023 · 0 comments · Fixed by #1463
Closed

Replace the autodetect platform logic by something that express in a clearer way that OpenShift Routes are available instead of the Platform used #1418

iblancasa opened this issue Feb 1, 2023 · 0 comments · Fixed by #1463
Labels
area:collector Issues for deploying collector help wanted Extra attention is needed

Comments

@iblancasa
Copy link
Contributor

Issue created from #1338.

The detection checks if OpenShift Routes API is installed. If true, it means we're running the Operator in OpenShift. The problem is that, for the E2E tests, we're installing the OpenShift Routes in KiND (Kubernetes). So, the E2E tests think they are running in OpenShift.
@pavolloffay pavolloffay added area:collector Issues for deploying collector help wanted Extra attention is needed labels Feb 1, 2023
@iblancasa iblancasa mentioned this issue Feb 2, 2023
Closed
@iblancasa iblancasa changed the title Decouple the logic to detect the platform from the availability of OpenShift Routes Replace the autodetect platform logic by something that express in a clearer way that OpenShift Routes are available instead of the Platform used Feb 7, 2023
@iblancasa iblancasa mentioned this issue Feb 9, 2023
Merged
@iblancasa iblancasa mentioned this issue Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:collector Issues for deploying collector help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
2 participants
@iblancasa @pavolloffay