Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release proposal 0.25.0 #2415

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Aug 17, 2021

💥 Breaking Change

  • opentelemetry-api-metrics, opentelemetry-context-zone-peer-dep, opentelemetry-context-zone, opentelemetry-core, opentelemetry-exporter-collector-grpc, opentelemetry-exporter-collector-proto, opentelemetry-exporter-collector, opentelemetry-exporter-jaeger, opentelemetry-exporter-prometheus, opentelemetry-exporter-zipkin, opentelemetry-instrumentation-fetch, opentelemetry-instrumentation-grpc, opentelemetry-instrumentation-http, opentelemetry-instrumentation-xml-http-request, opentelemetry-instrumentation, opentelemetry-propagator-jaeger, opentelemetry-sdk-metrics-base, opentelemetry-sdk-node, opentelemetry-sdk-trace-base, opentelemetry-sdk-trace-node, opentelemetry-sdk-trace-web, opentelemetry-shim-opentracing

🚀 (Enhancement)

  • opentelemetry-exporter-collector-grpc, opentelemetry-exporter-collector-proto, opentelemetry-exporter-collector, opentelemetry-exporter-zipkin
    • #1775 fix(@opentelemetry/exporter-collector): remove fulfilled promises cor… (@aabmass)
  • opentelemetry-exporter-collector
    • #2336 feat: use Blob in sendBeacon to add application/json type (@jufab)

🐛 (Bug Fix)

  • opentelemetry-instrumentation-fetch
    • #2411 fix(instrumentation-fetch): fetch(string, Request) silently drops request body (@t2t2)
  • opentelemetry-sdk-trace-base
    • #2396 fix: respect sampled flag in Span Processors, fix associated tests (@quickgiant)

📚 (Refine Doc)

  • Other
    • #2412 docs: fix examples in website_docs/instrumentation.md (@svrnm)
    • #2400 Website docs update 0821 (@svrnm)
  • opentelemetry-resources, opentelemetry-semantic-conventions

🏠 (Internal)

  • opentelemetry-core, opentelemetry-exporter-collector-grpc, opentelemetry-exporter-collector-proto, opentelemetry-instrumentation-http, opentelemetry-sdk-trace-node
  • opentelemetry-propagator-b3, opentelemetry-propagator-jaeger, opentelemetry-resources, opentelemetry-sdk-metrics-base
    • #2406 chore: Fix lint warnings in propagator-jaeger, propagator-b3, resources, and sdk-metrics-base packages (@alisabzevari)
  • opentelemetry-core
  • opentelemetry-resource-detector-aws, opentelemetry-resource-detector-gcp, opentelemetry-sdk-node
  • opentelemetry-exporter-collector-grpc, opentelemetry-exporter-collector-proto, opentelemetry-exporter-collector, opentelemetry-exporter-jaeger, opentelemetry-exporter-zipkin, opentelemetry-instrumentation-fetch, opentelemetry-instrumentation-grpc, opentelemetry-instrumentation-http, opentelemetry-instrumentation-xml-http-request, opentelemetry-sdk-node, opentelemetry-sdk-trace-node, opentelemetry-sdk-trace-web, opentelemetry-shim-opentracing
  • opentelemetry-api-metrics, opentelemetry-context-zone-peer-dep
  • Other
    • #2397 chore: change codeowners to point to team (@dyladan)
    • #2385 chore: move api into dependencies in integration tests (@Flarna)

Committers: 11

@dyladan dyladan requested a review from a team August 17, 2021 13:10
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2415 (0b438fb) into main (f129138) will increase coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2415      +/-   ##
==========================================
+ Coverage   92.14%   92.64%   +0.49%     
==========================================
  Files         120      137      +17     
  Lines        3998     4975     +977     
  Branches      844     1048     +204     
==========================================
+ Hits         3684     4609     +925     
- Misses        314      366      +52     
Impacted Files Coverage Δ
...ry-exporter-collector/src/CollectorExporterBase.ts 92.15% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.18% <0.00%> (ø)
...-sdk-trace-web/src/enums/PerformanceTimingNames.ts 100.00% <0.00%> (ø)
packages/opentelemetry-sdk-trace-web/src/utils.ts 94.90% <0.00%> (ø)
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)
...es/opentelemetry-context-zone-peer-dep/src/util.ts 100.00% <0.00%> (ø)
...ages/opentelemetry-exporter-collector/src/types.ts 100.00% <0.00%> (ø)
.../opentelemetry-exporter-collector/src/transform.ts 88.69% <0.00%> (ø)
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
... and 7 more

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe the SDK could be tagged as RC no ? Other blocking things were about instrumentation which isn't included right ?

@dyladan
Copy link
Member Author

dyladan commented Aug 17, 2021

i believe the SDK could be tagged as RC no ? Other blocking things were about instrumentation which isn't included right ?

How do you want to do that? Just in the README?

@vmarchaud
Copy link
Member

How do you want to do that? Just in the README?

Well i think it would be enough ? We could make a npm tag but from the experience with the API i think having it in the readme is way easier and enough for users

@dyladan
Copy link
Member Author

dyladan commented Aug 17, 2021

How do you want to do that? Just in the README?

Well i think it would be enough ? We could make a npm tag but from the experience with the API i think having it in the readme is way easier and enough for users

We already did that in the previous release
image

@vmarchaud
Copy link
Member

We already did that in the previous release

Didn't see mybad

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dyladan dyladan merged commit 0ef1fc2 into open-telemetry:main Aug 18, 2021
@dyladan dyladan deleted the 0.25.0-proposal branch August 18, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants