Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move detectors to opentelemetry-js-contrib repo #2392

Merged
merged 4 commits into from
Aug 9, 2021

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Aug 3, 2021

Which problem is this PR solving?

Short description of the changes

Refs: open-telemetry/opentelemetry-js-contrib#593

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #2392 (3938cd0) into main (3eb5386) will increase coverage by 0.28%.
The diff coverage is n/a.

❗ Current head 3938cd0 differs from pull request most recent head a7a3292. Consider uploading reports for the commit a7a3292 to get more accurate results

@@            Coverage Diff             @@
##             main    #2392      +/-   ##
==========================================
+ Coverage   92.35%   92.64%   +0.28%     
==========================================
  Files         128      137       +9     
  Lines        4253     4974     +721     
  Branches      870     1047     +177     
==========================================
+ Hits         3928     4608     +680     
- Misses        325      366      +41     
Impacted Files Coverage Δ
...es/opentelemetry-context-zone-peer-dep/src/util.ts 100.00% <0.00%> (ø)
...telemetry-sdk-trace-web/src/StackContextManager.ts 94.28% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.91% <0.00%> (ø)
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...ages/opentelemetry-exporter-collector/src/types.ts 100.00% <0.00%> (ø)
...-sdk-trace-web/src/enums/PerformanceTimingNames.ts 100.00% <0.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.18% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...kages/opentelemetry-exporter-collector/src/util.ts 100.00% <0.00%> (ø)
... and 7 more

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@obecny
Copy link
Member

obecny commented Aug 4, 2021

will wait with merging for sdk renaming packgages

@Flarna Flarna requested a review from a team August 6, 2021 08:18
@dyladan
Copy link
Member

dyladan commented Aug 6, 2021

Please fix conflicts

@vmarchaud vmarchaud merged commit 9790070 into open-telemetry:main Aug 9, 2021
@legendecas legendecas deleted the move-detectors branch August 9, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants